Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API that has reached EOL after Flutter 3.16 #139243

Closed
Piinks opened this issue Nov 29, 2023 · 1 comment · Fixed by flutter/website#10024
Closed

Remove deprecated API that has reached EOL after Flutter 3.16 #139243

Piinks opened this issue Nov 29, 2023 · 1 comment · Fixed by flutter/website#10024
Assignees
@Piinks
Labels
a: quality A truly polished experience c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@Piinks
Copy link
Contributor

Piinks commented Nov 29, 2023 •
edited

The time has come again. :)

These are the next batch of deprecations that have expired

Announcement

This should only be closed after the final migration guide for this batch lands in the website repo.
@Piinks Piinks added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. a: quality A truly polished experience P2 Important issues not at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Nov 29, 2023
@Piinks Piinks self-assigned this Nov 29, 2023
This was referenced Nov 29, 2023
Merged
Closed
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Nov 29, 2023
@Piinks Piinks mentioned this issue Nov 29, 2023
Merged
auto-submit bot pushed a commit that referenced this issue Nov 29, 2023
@gspencergoog
Remove deprecated PlatformMenuBar.body (#138509)
6295289 
Part of #139243

## Description

This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed.

## Tests
 - No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations
@Renzo-Olivares Renzo-Olivares mentioned this issue Nov 29, 2023
Merged
8 tasks
parlough pushed a commit to flutter/website that referenced this issue Nov 29, 2023
@Piinks
Reference sheet for post-3.16 deprecation clean up (#9870)
4af90a3 
Part of flutter/flutter#139243
With the release of 3.16, these APIs are next to be removed from the
framework.
This was referenced Nov 29, 2023
Closed
Merged
@Renzo-Olivares Renzo-Olivares mentioned this issue Nov 29, 2023
Merged
8 tasks
@QuncCccccc QuncCccccc mentioned this issue Nov 29, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this issue Dec 5, 2023
@Piinks
Removed deprecated NavigatorState.focusScopeNode (#139260)
4040570 
Part of #139243

Deprecated in #109702

The replacement for focusScopeNode is focusNode.enclosingScope
@Piinks Piinks mentioned this issue Dec 5, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this issue Dec 7, 2023
@Piinks
Reset deprecation period for setPubRootDirectories (#139592)
da7e5e3 
This deprecation period is being renewed after we found it affected many IDE plugins that had not yet migrated, but did not receive a warning during the deprecation period.
We also expected to have a migration guide since the migration is not always to simply rename to addPubRootDirectories. This will give another 1+ year for the migration to be completed.

Part of #139243
Will update announcement at flutter-announce to reflect this API will remain for a while longer.
atsansone pushed a commit to atsansone/website that referenced this issue Dec 11, 2023
@Piinks @atsansone
Reference sheet for post-3.16 deprecation clean up (flutter#9870)
ff8babf 
Part of flutter/flutter#139243
With the release of 3.16, these APIs are next to be removed from the
framework.
Gibbo97 pushed a commit to Gibbo97/flutter that referenced this issue Dec 13, 2023
@Piinks
Removed deprecated NavigatorState.focusScopeNode (flutter#139260)
2353b1d 
Part of flutter#139243

Deprecated in flutter#109702

The replacement for focusScopeNode is focusNode.enclosingScope
auto-submit bot pushed a commit that referenced this issue Dec 14, 2023
@Renzo-Olivares
Remove deprecated ThemeData.selectedRowColor (#139080)
5be1918 
Part of: #139243
caseycrogers pushed a commit to caseycrogers/flutter that referenced this issue Dec 29, 2023
@gspencergoog @caseycrogers
Remove deprecated PlatformMenuBar.body (flutter#138509)
a07ad0b 
Part of flutter#139243

## Description

This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed.

## Tests
 - No tests were using the deprecated attribute, so no tests were removed.

#FlutterDeprecations
Michal-MK pushed a commit to Michal-MK/flutter that referenced this issue Jan 8, 2024
@Renzo-Olivares @Michal-MK
Remove deprecated ThemeData.selectedRowColor (flutter#139080)
e3e04b6 
Part of: flutter#139243
Markzipan pushed a commit to Markzipan/flutter that referenced this issue Jan 9, 2024
@Piinks @Markzipan
Reset deprecation period for setPubRootDirectories (flutter#139592)
4c03d19 
This deprecation period is being renewed after we found it affected many IDE plugins that had not yet migrated, but did not receive a warning during the deprecation period.
We also expected to have a migration guide since the migration is not always to simply rename to addPubRootDirectories. This will give another 1+ year for the migration to be completed.

Part of flutter#139243
Will update announcement at flutter-announce to reflect this API will remain for a while longer.
Markzipan pushed a commit to Markzipan/flutter that referenced this issue Jan 9, 2024
@Renzo-Olivares @Markzipan
Remove deprecated ThemeData.selectedRowColor (flutter#139080)
f7c8e2c 
Part of: flutter#139243
@Piinks Piinks mentioned this issue Jan 10, 2024
Merged
3 tasks
parlough added a commit to flutter/website that referenced this issue Jan 10, 2024
@Piinks @parlough
Migration guide for deprecations removed after 3.16 release (#10024)
7772806 
This adds the migration guide for the deprecations that have been
removed since the 3.16 release.

Fixes flutter/flutter#139243

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Piinks Piinks

Labels
a: quality A truly polished experience c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migration guide for deprecations removed after 3.16 release Piinks/website
1 participant
@Piinks