Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate src/third_party/perfetto to src/flutter/third_party. #144204

Closed
matanlurey opened this issue Feb 27, 2024 · 4 comments
Closed

Migrate src/third_party/perfetto to src/flutter/third_party. #144204

matanlurey opened this issue Feb 27, 2024 · 4 comments
Assignees
@matanlurey @cbracken
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@matanlurey
Copy link
Contributor

Part of #67373.

If you think this will take longer than our check-in on March 11th, just LMK!
@matanlurey matanlurey added engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels Feb 27, 2024
@matanlurey matanlurey self-assigned this Feb 27, 2024
@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label Mar 4, 2024
This was referenced Mar 8, 2024
Open
Closed
Merged
Closed
cbracken added a commit to cbracken/dart_sdk that referenced this issue Mar 8, 2024
@cbracken
Support overriding perfetto_root_path
0d870c2 
As part of merging Flutter's flutter/buildroot and flutter/engine repos,
Flutter is migrating all third-party dependencies from //third_party to
//flutter/third_party.

This change allows consumers of the Dart SDK (notably Flutter), to
override the path of their third_party/perfetto directory.

Issue: flutter/flutter#144204
Part of: flutter/flutter#67373
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 9, 2024
@cbracken
Support overriding perfetto_root_path
c1058b6 
As part of merging Flutter's flutter/buildroot and flutter/engine repos,
Flutter is migrating all third-party dependencies from //third_party to
//flutter/third_party.

This change allows consumers of the Dart SDK (notably Flutter), to
override the path of their third_party/perfetto directory by setting
perfetto_root_path in //build_overrides/build.gn. The Dart SDK does
not override perfetto's path, but does override other variables
(perfetto_build_with_embedder) in the equivalent overrides file secondary/build_overrides/build.gn.

TEST=None. Refactor only; no semantic changes.

Issue: flutter/flutter#144204
Change-Id: Ie3835a5507a39bf2d68b1c86d42c626093358b17
Part of: flutter/flutter#67373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356622
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Chris Bracken <cbracken@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
@cbracken cbracken self-assigned this Mar 9, 2024
@cbracken
Copy link
Member

cbracken commented Mar 9, 2024

Landed https://dart-review.googlesource.com/c/sdk/+/356622 in the Dart SDK which, once it rolls into the engine, will allow flutter/engine#51272 to land.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 11, 2024
@cbracken
Update perfetto include directories
a735858 
In https://dart-review.googlesource.com/c/sdk/+/356622 we updated the
perfetto include directory in libprotozero_config to use
`perfetto_root_path` rather than hardcoding `//third_party/perfetto`.

Some Perfetto headers, however, #include a generated header, which is
located at `$root_gen_dir/$perfetto_root_path/build_config`. See
declaration of perfetto_build_flags.h and buildflag_gen_dir_ at:
https://flutter.googlesource.com/third_party/perfetto/+/refs/heads/main/gn/BUILD.gn#26

This was missed in the first patch since while the default local engine
build of Flutter DOES do all gn processing, it DOES NOT do a full Dart
build, our presubmits however, revealed the gap.

This updates the include directories for the config to use the correct
value as declared in perfetto.

TEST=None. Refactor only; no semantic changes.

Issue: flutter/flutter#144204
Change-Id: I44c1269af85e40eab8e397c3d099f5dc1bca1229
Part of: flutter/flutter#67373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356960
Commit-Queue: Chris Bracken <cbracken@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
@cbracken
Copy link
Member

Landed https://dart-review.googlesource.com/c/sdk/+/356960 as a followup. Once this rolls into the engine, I'll rebase flutter/engine#51272.

auto-submit bot pushed a commit to flutter/engine that referenced this issue Mar 12, 2024
@cbracken
Migrate perfetto to flutter/third_party (#51272)
c076d21 
Migrate perfetto from the buildroot's third_party directory to the engine's.

Issue: flutter/flutter#144204
Part of: flutter/flutter#67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@cbracken
Copy link
Member

Fixed!

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

@cbracken cbracken

Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matanlurey @cbracken @jonahwilliams