-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate perfetto to flutter/third_party #51272
Migrate perfetto to flutter/third_party #51272
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
634cd22
to
e8c37d1
Compare
e8c37d1
to
5e2dc3e
Compare
auto label is removed for flutter/engine/51272, due to - The status or check suite Mac mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Looks like some failures during
Looks like I need to patch the Dart SDK to perfetto config to update the include dir. |
Followup patch is out at https://dart-review.googlesource.com/c/sdk/+/356960 |
Migrate perfetto from the buildroot's third_party directory to the engine's. Issue: flutter/flutter#144808 Part of: flutter/flutter#67373
5e2dc3e
to
bb66085
Compare
…145018) flutter/engine@af1fd17...9db394d 2024-03-12 bdero@google.com [Impeller] Fix shader depth assignment & glyph atlas transform. (flutter/engine#51343) 2024-03-12 jacksongardner@google.com Reland "Move emscripten out of the buildroot into the flutter repo" (flutter/engine#51353) 2024-03-12 skia-flutter-autoroll@skia.org Roll Skia from c123cce23f20 to 6e1f7333b2c7 (1 revision) (flutter/engine#51356) 2024-03-12 skia-flutter-autoroll@skia.org Roll Skia from 32f1cb50734a to c123cce23f20 (9 revisions) (flutter/engine#51351) 2024-03-12 chris@bracken.jp Migrate perfetto to flutter/third_party (flutter/engine#51272) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Migrate perfetto from the buildroot's third_party directory to the engine's.
Issue: flutter/flutter#144204
Part of: flutter/flutter#67373
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.