-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] integration_test and driver tests are flaky in CanvasKit + debug mode #147731
Comments
This changes CanvasKit and Skwasm to be compiled and loaded as ES6 modules instead of as vanilla script tags. Currently, the emscripten JS files try to register themselves with require.js or AMD module loading systems. We suspect this is causing issues (flutter/flutter#149565) with DDC's module loading system, which itself uses require.js. This is probably also the fix for flutter/flutter#147731
flutter/engine#52023 landed, which I am fairly confident will eliminate the flakiness of these tests. Once that change rolls into the framework, I will look into re-enabling the debug integration tests. |
Reverts: #52023 Initiated by: eyebrowsoffire Reason for reverting: Causing issues in engine -> framework roll flutter/flutter#151139 Original PR Author: eyebrowsoffire Reviewed By: {ditman} This change reverts the following previous change: This changes CanvasKit and Skwasm to be compiled and loaded as ES6 modules instead of as vanilla script tags. Currently, the emscripten JS files try to register themselves with require.js or AMD module loading systems. We suspect this is causing issues (flutter/flutter#149565) with DDC's module loading system, which itself uses require.js. This is probably also the fix for flutter/flutter#147731
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
integration_test
andflutter drive
tests are flaky when running with--web-renderer=canvaskit --debug
.This is because there's an incompatibility between CanvasKit's and DDC's module loading systems. Both use requireJS, but there's a race that doesn't resolve cleanly.
Work is already underway on the Dart SDK side: dart-lang/sdk#55429.
This issue is for tracking the Flutter-side changes.
This issue will supersede #146189. The P0 will be solved by temporarily turning off
--debug
mode test shards.The text was updated successfully, but these errors were encountered: