Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need some feedback that the observatory is up and available to connect to #42

Closed
abarth opened this issue Nov 7, 2015 · 4 comments
Closed
Labels
c: new feature Nothing broken; request for a new capability tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@abarth
Copy link
Contributor

abarth commented Nov 7, 2015

From https://github.com/flutter/tools/issues/110

The CLI VM prints out Observatory listening on http://127.0.0.1:8989 when run w/ the observatory enabled. Perhaps the flutter runtime should to the same?

It looks like the VM doesn't print on startup if you use the default port of 8181. And parsing stdout for a token isn't the most reliable way of doing things.

We could change the flutter start command to not return until the process is up and running on android. Then we'd know, when that completes, that the observatory is ready to connect to.

@abarth abarth added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 7, 2015
@sethladd
Copy link
Contributor

sethladd commented Dec 8, 2015

cc @devoncarew still needed?

@devoncarew
Copy link
Member

Yup -

@Hixie Hixie added affects: dev experience c: new feature Nothing broken; request for a new capability labels Dec 12, 2015
@Hixie Hixie added this to the Blue Sky milestone Dec 12, 2015
@eseidelGoogle
Copy link
Contributor

We print this now.

@radensoft radensoft mentioned this issue May 9, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

No branches or pull requests

5 participants