Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling in Shrine item pages is only 30pfs on a Nexus 5 #5249

Closed
eseidelGoogle opened this issue Aug 5, 2016 · 7 comments
Closed

Scrolling in Shrine item pages is only 30pfs on a Nexus 5 #5249

eseidelGoogle opened this issue Aug 5, 2016 · 7 comments
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.

Comments

@eseidelGoogle
Copy link
Contributor

flutter_06

That screenshot is in a release build:

Flutter on channel master (from git@github.com:flutter/flutter.git)
Framework revision 4fe80830ca (8 minutes ago); engine revision 24511c9265

screenshot from 2016-08-05 09 18 21

dart-timeline-2016-7-5.json.zip

FYI @chinmaygarde
@eseidelGoogle eseidelGoogle added the customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. label Aug 5, 2016
@eseidelGoogle
Copy link
Contributor Author

Scrolls beautifully on my iPhone 6s.

@eseidelGoogle
Copy link
Contributor Author

@HansMuller worked around this using 4a8dbb0

@chinmaygarde
Copy link
Member

Should we close this ticket then?

@eseidelGoogle
Copy link
Contributor Author

@chinmaygarde my understanding from chat with @abarth was you felt something was still wrong here? I'm happy to close this and wait to see something like it come up again?

@HansMuller
Copy link
Contributor

We had to add a shadow (changed the cards' elevation from 0 to 1) to the grid items to get the corresponding raster's cached. That shouldn't have been necessary; still needs to be fixed.

@Hixie Hixie modified the milestone: Flutter 1.0 Sep 12, 2016
@Hixie Hixie added the framework flutter/packages/flutter repository. See also f: labels. label Sep 12, 2016
@eseidelGoogle eseidelGoogle added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Feb 3, 2017
@Hixie Hixie modified the milestones: 5: Make Hixie proud, 4: Next milestone Nov 14, 2017
aam added a commit to aam/flutter that referenced this issue May 17, 2018
@aam
Roll engine to 4374ccc.
69363ea 
Changes since last roll:
```
4374ccc Roll Dart to 43635d3372253262cbf51e55b2ccfceae4f94682. (flutter#5282)
8862465 [fuchsia] Update FIDL include paths. (flutter#5279)
a7b44d4 Only send a11y events if a11y is turned on (flutter#5281)
f218099 Roll src/third_party/skia/ 02faa2b99..94f585ed0 (8 commits) (flutter#5280)
30c649d [fuchsia] Teach engine how to set up an isolate from a list of kernel files. (flutter#5210)
c95d432 Roll src/third_party/skia/ 682c58da4..02faa2b99 (10 commits) (flutter#5277)
bbfe593 Enable flutter service protocol rpcs to run on UI isolate. (flutter#5263)
4dc0183 Roll src/third_party/skia/ 4c2a34e48..682c58da4 (1 commit) (flutter#5276)
ff884db Roll src/third_party/skia/ 5b8b472b3..4c2a34e48 (1 commit) (flutter#5274)
d6f0f2f Roll src/third_party/skia/ c8799aa92..5b8b472b3 (7 commits) (flutter#5273)
d1d5497 Drain any pending work on the IO thread before shutting down the platform view (flutter#5272)
e32e390 Roll Dart to a5c11d7d0329432ca37e35bb249b20f60aa0aa31. (flutter#5269)
db34bb6 Roll buildroot to 78cf6d88d1a8b6f8293649508f2c1db6ad385fb0 for newer GN for Windows. (flutter#5271)
645c15f Roll src/third_party/skia/ 6e9f34f0e..c8799aa92 (13 commits) (flutter#5270)
99b3262 Mark the linux group testonly (flutter#5268)
17a71f6 Build the flutter tester on Linux in the default group. (flutter#5267)
63fdebf Revert "Roll Dart to a5c11d7d0329432ca37e35bb249b20f60aa0aa31. (flutter#5259)" (flutter#5266)
755dbee Roll Dart to a5c11d7d0329432ca37e35bb249b20f60aa0aa31. (flutter#5259)
73a0014 Create an empty group that the Fuchsia bots use to determine the root_out_dir. (flutter#5265)
c7ab033 Support a model where the application creates a FlutterNativeView that is never destroyed (flutter#5256)
e463e80 Roll src/third_party/skia/ 81f60ecd9..6e9f34f0e (7 commits) (flutter#5264)
be6c517 Fix documentation mistake in painting.dart (flutter#5236)
fb303b9 Roll src/third_party/skia/ 6bbd386a0..81f60ecd9 (1 commit) (flutter#5262)
765b7d4 Roll src/third_party/skia/ 3b9effcb1..6bbd386a0 (2 commits) (flutter#5260)
c3c6c36 Create a session presentation backed Vsync waiter on Fuchsia. (flutter#5255)
f943345 Roll src/third_party/skia/ 8803ebb47..3b9effcb1 (8 commits) (flutter#5257)
f12b5a5 Roll src/third_party/skia/ 16ffdd4ed..8803ebb47 (8 commits) (flutter#5254)
cde5014 Roll src/third_party/skia/ 5140f9a8e..16ffdd4ed (4 commits) (flutter#5252)
4a5d8bc Roll src/third_party/skia/ b06a1eb4e..5140f9a8e (1 commit) (flutter#5251)
966ef68 Roll src/third_party/skia/ ec48812c5..b06a1eb4e (1 commit) (flutter#5250)
fb89534 Roll src/third_party/skia/ 96b0b46f2..ec48812c5 (1 commit) (flutter#5249)
5f57c59 Roll src/third_party/skia/ 3202ac4d2..96b0b46f2 (1 commit) (flutter#5248)
```
@goderbauer goderbauer added the engine flutter/engine repository. See also e: labels. label Dec 27, 2018
@cbracken
Copy link
Member

cbracken commented Nov 6, 2019

This issue should now be resolved - if we see a future regression we should open a new issue.

@cbracken cbracken closed this as completed Nov 6, 2019
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@chinmaygarde @cbracken @Hixie @goderbauer @HansMuller @eseidelGoogle