Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AnimatedSize. #5260

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Added AnimatedSize. #5260

merged 1 commit into from
Aug 18, 2016

Conversation

dragostis
Copy link
Contributor

Added a widget that implicitly animates the size of it child.

abarth
abarth reviewed Aug 5, 2016
View reviewed changes
packages/flutter/lib/src/rendering/animated_size.dart
Duration duration,
Curve curve,
RenderBox child
}) : super(child: child, alignment: FractionalOffset.center) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to control the alignment from the constructor as well.

@Hixie
Copy link
Contributor

Hixie commented Aug 9, 2016 •
edited

This PR is probably obsolete now. We should just use the full cross-fade widget you're working on.

Hixie
Hixie reviewed Aug 11, 2016
View reviewed changes
packages/flutter/lib/src/rendering/animated_size.dart
void _trigger() {
_controller
..removeListener(markNeedsLayout)
..value = 0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do forward(from: 0.0) rather than setting the value.

@Hixie
Copy link
Contributor

Hixie commented Aug 17, 2016

getting there! mostly just doc fixes needed now

HansMuller
HansMuller reviewed Aug 18, 2016
View reviewed changes
packages/flutter/lib/src/widgets/animated_size.dart
@required this.duration
}) : super(key: key, child: child);

/// How to align the child.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to explain when the alignment matters. For example: How the child is aligned within this widget as this widget's size is transitioned to match the child's size.

@HansMuller
Copy link
Contributor

LGTM modulo the small fixes/clarifications.

@dragostis
Added AnimatedSize.
9f2841a 
Added a widget that implicitly animates the size of it child.
@dragostis dragostis merged commit 6e9bbca into flutter:master Aug 18, 2016
@Hixie
Copy link
Contributor

Hixie commented Aug 18, 2016

Instead of expect(foo, equals(1)) just write expect(foo, 1).
Instead of expect(foo.length, equals(1)) just write expect(foo, hasLength(1)).

aam added a commit to aam/flutter that referenced this pull request May 17, 2018
@aam
Roll engine to 4374ccc.
69363ea 
Changes since last roll:
```
4374ccc Roll Dart to 43635d3372253262cbf51e55b2ccfceae4f94682. (flutter#5282)
8862465 [fuchsia] Update FIDL include paths. (flutter#5279)
a7b44d4 Only send a11y events if a11y is turned on (flutter#5281)
f218099 Roll src/third_party/skia/ 02faa2b99..94f585ed0 (8 commits) (flutter#5280)
30c649d [fuchsia] Teach engine how to set up an isolate from a list of kernel files. (flutter#5210)
c95d432 Roll src/third_party/skia/ 682c58da4..02faa2b99 (10 commits) (flutter#5277)
bbfe593 Enable flutter service protocol rpcs to run on UI isolate. (flutter#5263)
4dc0183 Roll src/third_party/skia/ 4c2a34e48..682c58da4 (1 commit) (flutter#5276)
ff884db Roll src/third_party/skia/ 5b8b472b3..4c2a34e48 (1 commit) (flutter#5274)
d6f0f2f Roll src/third_party/skia/ c8799aa92..5b8b472b3 (7 commits) (flutter#5273)
d1d5497 Drain any pending work on the IO thread before shutting down the platform view (flutter#5272)
e32e390 Roll Dart to a5c11d7d0329432ca37e35bb249b20f60aa0aa31. (flutter#5269)
db34bb6 Roll buildroot to 78cf6d88d1a8b6f8293649508f2c1db6ad385fb0 for newer GN for Windows. (flutter#5271)
645c15f Roll src/third_party/skia/ 6e9f34f0e..c8799aa92 (13 commits) (flutter#5270)
99b3262 Mark the linux group testonly (flutter#5268)
17a71f6 Build the flutter tester on Linux in the default group. (flutter#5267)
63fdebf Revert "Roll Dart to a5c11d7d0329432ca37e35bb249b20f60aa0aa31. (flutter#5259)" (flutter#5266)
755dbee Roll Dart to a5c11d7d0329432ca37e35bb249b20f60aa0aa31. (flutter#5259)
73a0014 Create an empty group that the Fuchsia bots use to determine the root_out_dir. (flutter#5265)
c7ab033 Support a model where the application creates a FlutterNativeView that is never destroyed (flutter#5256)
e463e80 Roll src/third_party/skia/ 81f60ecd9..6e9f34f0e (7 commits) (flutter#5264)
be6c517 Fix documentation mistake in painting.dart (flutter#5236)
fb303b9 Roll src/third_party/skia/ 6bbd386a0..81f60ecd9 (1 commit) (flutter#5262)
765b7d4 Roll src/third_party/skia/ 3b9effcb1..6bbd386a0 (2 commits) (flutter#5260)
c3c6c36 Create a session presentation backed Vsync waiter on Fuchsia. (flutter#5255)
f943345 Roll src/third_party/skia/ 8803ebb47..3b9effcb1 (8 commits) (flutter#5257)
f12b5a5 Roll src/third_party/skia/ 16ffdd4ed..8803ebb47 (8 commits) (flutter#5254)
cde5014 Roll src/third_party/skia/ 5140f9a8e..16ffdd4ed (4 commits) (flutter#5252)
4a5d8bc Roll src/third_party/skia/ b06a1eb4e..5140f9a8e (1 commit) (flutter#5251)
966ef68 Roll src/third_party/skia/ ec48812c5..b06a1eb4e (1 commit) (flutter#5250)
fb89534 Roll src/third_party/skia/ 96b0b46f2..ec48812c5 (1 commit) (flutter#5249)
5f57c59 Roll src/third_party/skia/ 3202ac4d2..96b0b46f2 (1 commit) (flutter#5248)
```
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dragostis @Hixie @HansMuller @abarth