Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like a way to opt-into in-progress features #5642

Closed
eseidelGoogle opened this issue Aug 29, 2016 · 8 comments
Closed

Would like a way to opt-into in-progress features #5642

eseidelGoogle opened this issue Aug 29, 2016 · 8 comments
Labels
customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. framework flutter/packages/flutter repository. See also f: labels.

Comments

@eseidelGoogle
Copy link
Contributor

This came out of conversation with @abarth yesterday. Some customers (including the Gallery) will want to disable in-progress features (like the back-gesture which just landed last week). Having a way to do so would be nice.

Ideally it would be possible to run the gallery with in-progress features, compile-time or runtime or however.

I would recommend that this choice not be just specific to the gallery since other apps are going to want this. Another alternative would be that we use branches for feature development, but personally I've had less success with that in the past. Up to you all.

Thoughts @Hixie @HansMuller @mpcomplete?

@eseidelGoogle eseidelGoogle added framework flutter/packages/flutter repository. See also f: labels. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels Aug 29, 2016
@sethladd sethladd changed the title Would like a way to disable in-progress features Would like a way to opt-into in-progress features Aug 29, 2016
@Hixie
Copy link
Contributor

Hixie commented Aug 29, 2016

I would argue that we shouldn't ship in-progress features. The existence of an in-progress feature should be a stop-ship bug for releasing to the alpha branch. This means it's fine to check in in-progress features that you're actively working on and expect to have done soon, but it's not ok to check it half-done work then not fix it. If we get to the point of wanting to ship and we still have in-progress work, we should remove it, because otherwise we are taking on technical debt.

@sethladd
Copy link
Contributor

releasing to the alpha branch.

We have no process for the alpha branch :) Let's chat about this in person.

@mpcomplete
Copy link
Contributor

I think we should stick to something simple for now. The back gesture should just be disabled (hard-coded) until it's ready. I don't see a need for customers to be able to pick and choose which "alpha" features they want.

That said, I think there's value in keeping in-progress features checked into trunk, even in a disabled state.

@Hixie
Copy link
Contributor

Hixie commented Aug 29, 2016

Disabled features will bit-rot and just cause us pain down the road.

@Hixie
Copy link
Contributor

Hixie commented Aug 29, 2016

@sethladd The alpha release process is https://github.com/flutter/flutter/wiki/Release-process

@sethladd
Copy link
Contributor

Great! We might want to add "everything is green on our dashboard buildbots".

@Hixie Hixie modified the milestone: Flutter 1.0 Sep 12, 2016
@eseidelGoogle
Copy link
Contributor Author

This hasn't come up since. Closing for now.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

No branches or pull requests

4 participants