Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back button in upper left is hard to register taps (target too small?) #575

Closed
sethladd opened this issue Nov 24, 2015 · 6 comments · Fixed by #648
Closed

Back button in upper left is hard to register taps (target too small?) #575

sethladd opened this issue Nov 24, 2015 · 6 comments · Fixed by #648
Assignees
@abarth

Comments

@sethladd
Copy link
Contributor

On one of our demo apps, the upper left back arrow is fairly hard to tap. Sometimes I get it right, but enough time it's acting like the tap wasn't registered.

Is this a known issue with our back button?
@sethladd
Copy link
Contributor Author

cc @Hixie @collinjackson

@abarth
Copy link
Contributor

abarth commented Nov 24, 2015

Known issue. We could paper over it pretty easily, but the real fix is to add the radial reaction. If it's annoying, let me know and I'll paper over it.

@abarth
Copy link
Contributor

abarth commented Nov 24, 2015

#82 is the issue for the real fix.

@sethladd
Copy link
Contributor Author

It blocks our "caveat-free demo" but otherwise not blocked. Let's go for the real fix.

@abarth abarth self-assigned this Dec 1, 2015
abarth added a commit to abarth/flutter that referenced this issue Dec 1, 2015
@abarth
Makes it easier to hit IconButton
4e6b526 
The right fix here is to use a radial reaction, but for now we can just make
the gesture detector including the padding acround the icon in its hit test
region.

Fixes flutter#575
@abarth abarth mentioned this issue Dec 1, 2015
Merged
@sethladd
Copy link
Contributor Author

sethladd commented Dec 3, 2015

Thanks for the fix!!

@l1x2d3 l1x2d3 mentioned this issue Sep 8, 2020
Closed
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abarth abarth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes it easier to hit IconButton abarth/flutter
2 participants
@sethladd @abarth