dialog background color is not configurable

[lequem]

In the dialog.dart file, line 44 and 46, the background color is set staticly and not configurable for Dialogs, whereas in ThemeData class, we can configure everything for the application.

I propose to define the new property dialogBackgroundColor in the ThemeData class and use it in the dialog.dart file.

[lequem]

I have pulled a request to patch this but the travis task failed and I don't understand why.

[sethladd]

PR is here: #7321

[sethladd]

cc @cbracken @yjbanov does the travis failure look familiar?

[cbracken]

Travis run looks green after @abarth's re-run. Is there a way to get at the previous (failed) run to take a look?

[abarth]

@cbracken Sorry, next time I'll save the log.

[FlutterIODev]

Can I set the color for a specific dialog not for all of my app dialogs?

[yjbanov]

@FlutterIODev something along these lines should do it (but I haven't tried myself):

Theme(
  data: themeDataWithCustomDialogColor,
  child: Builder(builder: (BuildContext contextWithNewTheme) {
    // some widget here will be calling `showDialog`. When it
    // does that, it should pass `contextWithNewTheme` to it,
    // e.g. `showDialog(context: contextWithNewTheme, ...);`
  }),
);

Having to wrap like that is a bit annoying, but I think it's consequence of #12655. Maybe @Hixie knows of a better way.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.