Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Material 2 text style properties #98746

Closed
Tracked by #91772
rami-a opened this issue Feb 18, 2022 · 3 comments · Fixed by #109817
Closed
Tracked by #91772

Deprecate Material 2 text style properties #98746

rami-a opened this issue Feb 18, 2022 · 3 comments · Fixed by #109817
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@rami-a
Copy link
Contributor

rami-a commented Feb 18, 2022

Now that Material 3 text styles have been added to the TextTheme, we can deprecate the Material 2 styles (just like we did for Material 1).

Proposal

  • Deprecate (and eventually remove following the official deprecation policy) M2 text styles from TextTheme, for example display1, bodyText2, etc.
@rami-a rami-a added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter labels Feb 18, 2022
@rami-a rami-a mentioned this issue Feb 18, 2022
Closed
4 tasks
@bernaferrari
Copy link
Contributor

Can we make the newer styles not nullable?

@iapicca
Copy link
Contributor

iapicca commented Feb 20, 2022

shold this be tracked in
#91605
https://github.com/flutter/flutter/projects/211 ?

@guidezpl guidezpl changed the title [Material 3] Deprecate Material 2 text style properties Deprecate Material 2 text style properties May 24, 2022
@HansMuller HansMuller mentioned this issue Aug 11, 2022
Open
42 tasks
@Piinks Piinks mentioned this issue Aug 19, 2022
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
No open projects
Material 3
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate 2018 text theme parameters Piinks/flutter
3 participants
@bernaferrari @rami-a @iapicca