Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create template splash screens for Android and iOS #11505

Merged
merged 9 commits into from
Aug 15, 2017

Conversation

xster
Copy link
Member

@xster xster commented Aug 3, 2017

Fixes #8147

This add 81kB to a newly flutter created project.

@Hixie
Copy link
Contributor

Hixie commented Aug 3, 2017

iirc @abarth had opinions about doing this

@xster
Copy link
Member Author

xster commented Aug 3, 2017

I'll add some splash screen instructions (probably to https://flutter.io/assets-and-images) in a separate website PR

@Hixie
Copy link
Contributor

Hixie commented Aug 8, 2017

I would rather we didn't show the Flutter logo by default. Our developers' apps' users don't care that our developers use Flutter. (Also if we do decide to show the logo, we should show the right one -- these PNGs have the SVG rendering error.)

Can we make these default splash screens just black, maybe?

@xster
Copy link
Member Author

xster commented Aug 8, 2017

You're right, the svgs do look broken. Seems like the illustrator vectors in the same directory are ok. Swapped out assets for those one.

It's not so much about showing the flutter logo as having a template for developers to drop in assets for splash screens without having to do all the work that's in this PR.

We can document on the website how to remove image assets to just have static colors but I think for developers, removing will be a lot easier than adding. But I think we can use a different image placeholder if there's another one you prefer.

@Hixie
Copy link
Contributor

Hixie commented Aug 8, 2017

I don't mind having a placeholder image, I just think it should be all-black or something like that.

Many developers are just writing little apps for their own personal use. They don't want to have to go and remove our big logo to have a professional-looking app. They just want an out-of-the-box polished experience. It's bad enough that we use our logo for the icon. ;-)

@xster
Copy link
Member Author

xster commented Aug 8, 2017

Did you mean a black box in a white background?

@xster
Copy link
Member Author

xster commented Aug 9, 2017

Made the changes we talked about, removed the actual assets. Left the hookups.

@Hixie
Copy link
Contributor

Hixie commented Aug 9, 2017

RSLGTM

The approach LGTM. I'm totally ignorant about the actual files you're modifying. :-)

@xster
Copy link
Member Author

xster commented Aug 14, 2017

I tweaked it again. The iOS side was giving warnings in Xcode and sometimes while running. Felt unclean. Added back a 1px transparent png for placeholder.

@xster xster merged commit 1ad4a08 into flutter:master Aug 15, 2017
@xster xster deleted the splash_screen_template branch August 15, 2017 00:20
xster added a commit that referenced this pull request Aug 15, 2017
xster added a commit that referenced this pull request Aug 15, 2017
* Revert "Create template splash screens for Android and iOS (#11505)"

This reverts commit 1ad4a08.

* Revert "Roll engine (#11619)"

This reverts commit ea78f44.
@coveralls
Copy link

Coverage Status

Coverage decreased (-46.7%) to 38.06% when pulling 46038d9 on xster:splash_screen_template into 4cb3a98 on flutter:master.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter create should make an app with a non-white splash screen
4 participants