-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create template splash screens for Android and iOS #11505
Conversation
iirc @abarth had opinions about doing this |
I'll add some splash screen instructions (probably to https://flutter.io/assets-and-images) in a separate website PR |
I would rather we didn't show the Flutter logo by default. Our developers' apps' users don't care that our developers use Flutter. (Also if we do decide to show the logo, we should show the right one -- these PNGs have the SVG rendering error.) Can we make these default splash screens just black, maybe? |
You're right, the svgs do look broken. Seems like the illustrator vectors in the same directory are ok. Swapped out assets for those one. It's not so much about showing the flutter logo as having a template for developers to drop in assets for splash screens without having to do all the work that's in this PR. We can document on the website how to remove image assets to just have static colors but I think for developers, removing will be a lot easier than adding. But I think we can use a different image placeholder if there's another one you prefer. |
I don't mind having a placeholder image, I just think it should be all-black or something like that. Many developers are just writing little apps for their own personal use. They don't want to have to go and remove our big logo to have a professional-looking app. They just want an out-of-the-box polished experience. It's bad enough that we use our logo for the icon. ;-) |
Did you mean a black box in a white background? |
7b2fec5
to
dc0c613
Compare
Made the changes we talked about, removed the actual assets. Left the hookups. |
dc0c613
to
06d3ca6
Compare
I tweaked it again. The iOS side was giving warnings in Xcode and sometimes while running. Felt unclean. Added back a 1px transparent png for placeholder. |
Fixes #8147
This add
81kBto a newlyflutter create
d project.