Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Remaining Packaging Builders #116683

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add Remaining Packaging Builders #116683

merged 4 commits into from
Dec 8, 2022

Conversation

sealesj
Copy link
Contributor

@sealesj sealesj commented Dec 7, 2022 •
edited

This change adds the remaining packaging builders needed for the stable branch.

Addresses issue #115489

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj removed the request for review from keyonghan December 7, 2022 19:57
@sealesj sealesj changed the title Add Remaining Add Remaining Packaging Builders Dec 7, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@sealesj
Copy link
Contributor Author

sealesj commented Dec 7, 2022

cc @yusuf-goog @drewroengoogle

godofredoc
godofredoc reviewed Dec 7, 2022
View reviewed changes
.ci.yaml Show resolved Hide resolved
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2022
@auto-submit auto-submit bot merged commit e52449b into flutter:master Dec 8, 2022
@sealesj sealesj deleted the add-remaining-packaging-builders branch December 8, 2022 17:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2022
@engine-flutter-autoroll
e52449b64 Add Remaining Packaging Builders (flutter/flutter#116683)
5adcbdb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2022
@engine-flutter-autoroll
e52449b64 Add Remaining Packaging Builders (flutter/flutter#116683)
3b303ee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 9, 2022
@engine-flutter-autoroll
e52449b Add Remaining Packaging Builders (flutter/flutter#116683)
f76c488
godofredoc pushed a commit to godofredoc/flutter that referenced this pull request Dec 14, 2022
@sealesj @godofredoc
Add Remaining Packaging Builders (flutter#116683)
9816d5d 
* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation
XilaiZhang pushed a commit that referenced this pull request Dec 14, 2022
@godofredoc @sealesj
CP: ci.yaml changes for packaging (#117038)
199c4bf 
* Migrate Packaging Builders to .ci.yaml (#115569)

* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>

* use deploy suffix (#116533)

* Update docs_deploy builder with the real name. (#116631)

This is removing the temporary comments and simplifying the name.

Bug: #115489

* Add Remaining Packaging Builders (#116683)

* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass drone_dimensions as part of the main target. (#116812)

* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: #116794

* Use dimensions instead of drone_dimensions.

* Use a map format.

Co-authored-by: sealesj <103135467+sealesj@users.noreply.github.com>
godofredoc pushed a commit to godofredoc/flutter that referenced this pull request Dec 15, 2022
@sealesj @godofredoc
Add Remaining Packaging Builders (flutter#116683)
9365c6d 
* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation
godofredoc added a commit that referenced this pull request Dec 15, 2022
@godofredoc @sealesj
CP: ci.yaml changes for packaging (#117133)
135454a 
* Migrate Packaging Builders to .ci.yaml (#115569)

* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>

* Revert deleted line.

* use deploy suffix (#116533)

* Update docs_deploy builder with the real name. (#116631)

This is removing the temporary comments and simplifying the name.

Bug: #115489

* Add Remaining Packaging Builders (#116683)

* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass drone_dimensions as part of the main target. (#116812)

* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: #116794

* Use dimensions instead of drone_dimensions.

* Use a map format.

Co-authored-by: sealesj <103135467+sealesj@users.noreply.github.com>
godofredoc pushed a commit to godofredoc/flutter that referenced this pull request Dec 16, 2022
@sealesj @godofredoc
Add Remaining Packaging Builders (flutter#116683)
4077f8d 
* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation
godofredoc added a commit that referenced this pull request Dec 16, 2022
@godofredoc @sealesj
CPs: ci.yaml changes for packaging (#117196)
9623d32 
* Migrate Packaging Builders to .ci.yaml (#115569)

* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>

* use deploy suffix (#116533)

* Update docs_deploy builder with the real name. (#116631)

This is removing the temporary comments and simplifying the name.

Bug: #115489

* Add Remaining Packaging Builders (#116683)

* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass drone_dimensions as part of the main target. (#116812)

* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: #116794

* Use dimensions instead of drone_dimensions.

* Use a map format.

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass dimension explicitly to mac x64 packaging. (#117172)

Without passing this dimension there is a chance that the build will
run on a arm64 machine.

Co-authored-by: sealesj <103135467+sealesj@users.noreply.github.com>
@ScreamingSyntax ScreamingSyntax mentioned this pull request Dec 16, 2022
Closed
8 tasks
@mHelenaR mHelenaR mentioned this pull request Dec 20, 2022
Closed
8 tasks
@crimdev5 crimdev5 mentioned this pull request Dec 23, 2022
Closed
8 tasks
@malikabdullahnaazar malikabdullahnaazar mentioned this pull request Dec 25, 2022
Closed
8 tasks
This was referenced Dec 30, 2022
Closed
Closed
@Ramzi-dr Ramzi-dr mentioned this pull request Jan 8, 2023
Closed
8 tasks
@emresezer-blog emresezer-blog mentioned this pull request Jan 11, 2023
Closed
8 tasks
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@sealesj @gspencergoog
Add Remaining Packaging Builders (flutter#116683)
d4946c3 
* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation
This was referenced Jan 21, 2023
Closed
Closed
@IsaTunahan IsaTunahan mentioned this pull request Jan 24, 2023
Closed
8 tasks
@ridwanyinusa ridwanyinusa mentioned this pull request Jan 29, 2023
Closed
8 tasks
@talebmohammedsaid talebmohammedsaid mentioned this pull request Jan 30, 2023
Closed
8 tasks
@memodlike memodlike mentioned this pull request Feb 5, 2023
Closed
8 tasks
@Dragan1992 Dragan1992 mentioned this pull request Feb 11, 2023
Closed
8 tasks
@Vinubrice Vinubrice mentioned this pull request Mar 2, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sealesj @godofredoc