Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPs: ci.yaml changes for packaging #117196

Merged

Conversation

godofredoc
Copy link
Contributor

CP: 30fc993
CP: 1b05653
CP: e07240e
CP: e52449b
CP: 1da8f4e
CP: bd0791b
CP: 1da8f4e
CP: a41c447

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

sealesj and others added 8 commits December 15, 2022 18:19
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
This is removing the temporary comments and simplifying the name.

Bug: flutter#115489
* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation
It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43
* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: flutter#116794

* Use dimensions instead of drone_dimensions.

* Use a map format.
It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43
Without passing this dimension there is a chance that the build will
run on a arm64 machine.
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@godofredoc godofredoc merged commit 9623d32 into flutter:flutter-3.7-candidate.1 Dec 16, 2022
@godofredoc godofredoc deleted the flutter-3.7-candidate.1 branch December 16, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants