Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Re-land#2] Button padding M3 #119498

Merged
merged 206 commits into from Jan 30, 2023
Merged

[Re-land#2] Button padding M3 #119498

merged 206 commits into from Jan 30, 2023

Conversation

esouthren
Copy link
Contributor

@esouthren esouthren commented Jan 30, 2023 •
edited

Re-land of #118449.

Previous re-land required a g3fix which has been submitted preemptively (see cl/504765742 and chat in Flutter Rollers).

esouthren and others added 30 commits January 12, 2023 20:19
@esouthren
init scaled changes
1b4d4f4
@esouthren
add correct padding values for M3
9d86acb
@esouthren
revert unneeded change
9f33957
@esouthren @guidezpl
Update packages/flutter/lib/src/material/text_button.dart
cc273e4 
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
@esouthren @guidezpl
Update packages/flutter/lib/src/material/text_button.dart
ac0bf49 
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
@esouthren
comment fixes
7aa06ae
@esouthren
test update
d4fe3e3
@esouthren
docstring fixes
3dc1e4e
@engine-flutter-autoroll @esouthren
e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy6…
210e981 
…4-PEXPer... (flutter/engine#38558) (flutter#117779)
@engine-flutter-autoroll @esouthren
Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter…
52e1f29 
…#117781)

* 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889)

* 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886)
@engine-flutter-autoroll @esouthren
4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (f…
5af1787 
…lutter/engine#38560) (flutter#117783)
@engine-flutter-autoroll @esouthren
3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (f…
912760d 
…lutter#117785)
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (f…
7c8c0b9 
…lutter#117788)

* 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561)

* 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563)
@engine-flutter-autoroll @esouthren
a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/eng…
1003b1e 
…ine#38565) (flutter#117790)
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (f…
fb302fa 
…lutter#117795)

* e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546)

* 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562)
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (f…
60409a3 
…lutter#117797)

* fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554)

* 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568)
@engine-flutter-autoroll @esouthren
9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (
c6da592 
flutter/engine#38569) (flutter#117799)
@engine-flutter-autoroll @esouthren
0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEj…
bfa7ccb 
…R5AkOr4d... (flutter/engine#38571) (flutter#117800)
@engine-flutter-autoroll @esouthren
e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (f…
c93ce57 
…lutter/engine#38572) (flutter#117802)
@engine-flutter-autoroll @esouthren
af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (f…
32ec731 
…lutter/engine#38574) (flutter#117804)
@engine-flutter-autoroll @esouthren
7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (
876ee1c 
flutter/engine#38575) (flutter#117805)
@engine-flutter-autoroll @esouthren
d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW…
283eb85 
…8UUSWAOcqA... (flutter/engine#38578) (flutter#117817)
@engine-flutter-autoroll @esouthren
b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutte…
e035f2d 
…r/plugins#6892) (flutter#117824)
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (f…
e8a47c6 
…lutter#117830)

* 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579)

* 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544)
@engine-flutter-autoroll @esouthren
b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (
e608c91 
flutter/engine#38580) (flutter#117832)
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (f…
7d34566 
…lutter#117834)

* 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577)

* f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581)
@engine-flutter-autoroll @esouthren
932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI…
284b78c 
…4aC9z7W4mI... (flutter/engine#38584) (flutter#117840)
@engine-flutter-autoroll @esouthren
3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWR…
eca12c8 
…ElkQ2P3vJz... (flutter/engine#38585) (flutter#117846)
@engine-flutter-autoroll @esouthren
Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (f…
514b64b 
…lutter#117856)

* 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586)

* a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587)
@engine-flutter-autoroll @esouthren
0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqT…
a0fabfe 
…c632VsY14L... (flutter/engine#38588) (flutter#117858)
CaseyHillers added a commit that referenced this pull request Jan 31, 2023
@CaseyHillers
Revert "[Re-land#2] Button padding M3 (#119498)"
793fadd 
This reverts commit 530c3f2.
@CaseyHillers CaseyHillers mentioned this pull request Jan 31, 2023
Merged
CaseyHillers pushed a commit that referenced this pull request Jan 31, 2023
Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)
7ba4406 
This reverts commit 530c3f2.
CaseyHillers pushed a commit that referenced this pull request Jan 31, 2023
[CP] Revert "[Re-land#2] Button padding M3 (#119498)" (#119597) (#119598
6a827d7 
)

This reverts commit 530c3f2.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Jan 31, 2023
Revert "[Re-land#2] Button padding M3 (flutter#119498)" (flutter#119597)
74d42fa 
This reverts commit 530c3f2.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
bc2dd44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
2c3995a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
30354be
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
056e269
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
6ae62e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
d68c5c0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
530c3f2d1 [Re-land#2] Button padding M3 (flutter/flutter#119498)
b17386a
CaseyHillers added a commit that referenced this pull request Jan 31, 2023
@CaseyHillers
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)"
9c3400c 
This reverts commit 7ba4406.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498)
31c6795
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498)
e1f8ff7
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Feb 1, 2023
@engine-flutter-autoroll
Roll Flutter from 0a22a1d to d278808 (58 revisions) (#7078)
36d8066 
* 472b887 0ec8e2802 Roll Fuchsia Mac SDK from 9y7C2oamTv6Py4JSC... to EAFnGijD0l5QxaPxF... (flutter/engine#39236) (flutter/flutter#119461)

* 15cd00f a7bb0e410 Roll Fuchsia Linux SDK from 1D63BqURfJdG4r3CK... to xTXbcsPr5GJvFSLha... (flutter/engine#39238) (flutter/flutter#119482)

* 530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498)

* 17eb2e8 Ability to disable the browser's context menu on web (flutter/flutter#118194)

* df8ad3d roll packages (flutter/flutter#119370)

* b68cebd roll packages (flutter/flutter#119530)

* 59d80dc [Android] Add explicit exported tag to Linux_android flavors test (flutter/flutter#117542)

* 458b298 Refactoring to use `ver` command instead of `systeminfo` (flutter/flutter#119304)

* 54405bf fixes PointerEventConverter to handle malformed scrolling event (flutter/flutter#118124)

* e69ea6d Support flipping mouse scrolling axes through modifier keys (flutter/flutter#115610)

* 92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter/engine#39139) (flutter/flutter#119546)

* 7477d7a Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (flutter/flutter#119529)

* 6c12e39 Introduce ParagraphBoundary subclass for text editing (flutter/flutter#116549)

* b227df3 Hint text semantics to be excluded in a11y read out if hintText is not visible. (flutter/flutter#119198)

* 18c7f8a Fix typo in --machine help text (flutter/flutter#119563)

* 329f86a Make a few values non-nullable in cupertino (flutter/flutter#119478)

* c4520bc b2efe0175 [web] Expose felt flag for building CanvasKit Chromium (flutter/engine#39201) (flutter/flutter#119567)

* 8898f4f Marks Mac_android run_debug_test_android to be unflaky (flutter/flutter#117468)

* 1f0b6fb Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (flutter/flutter#119253)

* edaeec8 Roll Flutter Engine from b2efe01754ef to 5011144c0b46 (3 revisions) (flutter/flutter#119578)

* 865dc5c Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (flutter/flutter#119584)

* 1148a2a Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (flutter/flutter#119359)

* 2340902 Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (flutter/flutter#119586)

* 65900b7 Remove deprecated AnimatedSize.vsync parameter (flutter/flutter#119186)

* 5b6572f Add debug diagnostics to channels integration test (flutter/flutter#119579)

* 504e565 Roll Flutter Engine from 77218818138f to 9448f2966c11 (3 revisions) (flutter/flutter#119592)

* 7ba4406 Revert "[Re-land#2] Button padding M3 (#119498)" (flutter/flutter#119597)

* 2c34a88 Roll Flutter Engine from 9448f2966c11 to 72abe0e4b828 (3 revisions) (flutter/flutter#119603)

* df0ab40 Roll Plugins from ff84c44 to 9da327c (15 revisions) (flutter/flutter#119629)

* 67d07a6 [flutter_tools] Fix parsing of existing DDS URIs from exceptions (flutter/flutter#119506)

* d272a3a Reland: [macos] add flavor options to tool commands (flutter/flutter#119564)

* a16d82c aa00da3c1 Roll Skia from fc31f43cc40a to 3c6eb76a683a (1 revision) (flutter/engine#39280) (flutter/flutter#119605)

* f6b0c6d Use first Dart VM Service found with mDNS if there are duplicates (flutter/flutter#119545)

* d4c7485 Make Decoration.padding non-nullable (flutter/flutter#119581)

* 2fccf4d Remove MediaQuery from WidgetsApp (flutter/flutter#119377)

* 9b3b9cf Roll Flutter Engine from aa00da3c1612 to cd2e8885e491 (6 revisions) (flutter/flutter#119639)

* 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195)

* e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515)

* 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640)

* 0e22aca Add support for image insertion on Android (flutter/flutter#110052)

* ff22813 separatorBuilder can't return null (flutter/flutter#119566)

* 60c1f29 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645)

* fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653)

* 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655)

* 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644)

* 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033)

* dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670)

* 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669)

* 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675)

* 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595)

* 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683)

* a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439)

* e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686)

* 97d273c CupertinoThemeData equality (flutter/flutter#119480)

* 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688)

* b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695)

* 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706)

* d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)
CaseyHillers added a commit that referenced this pull request Feb 17, 2023
@CaseyHillers
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)"
d6723b9 
This reverts commit 7ba4406.
XilaiZhang pushed a commit that referenced this pull request Feb 22, 2023
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)" (#…
9241426 
…119656)

This reverts commit 7ba4406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet