-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support safe area and scrolling in the NavigationDrawer (#116995) #119555
Merged
XilaiZhang
merged 3 commits into
flutter:flutter-3.7-candidate.1
from
Piinks:pickDrawerFix
Feb 1, 2023
Merged
Support safe area and scrolling in the NavigationDrawer (#116995) #119555
XilaiZhang
merged 3 commits into
flutter:flutter-3.7-candidate.1
from
Piinks:pickDrawerFix
Feb 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update navigation_drawer.dart * Update navigation_drawer_test.dart * Update navigation_drawer_test.dart * update tests * Update navigation_drawer_test.dart * Update navigation_drawer_test.dart
TahaTesser
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 2, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 2, 2023
…#3143) * 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648) * 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963) * c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555) * ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384) * 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 3, 2023
stuartmorgan
pushed a commit
to flutter/plugins
that referenced
this pull request
Feb 3, 2023
…#7091) * 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648) * 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963) * c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555) * ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384) * 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Maatteogekko
pushed a commit
to Maatteogekko/packages
that referenced
this pull request
Feb 4, 2023
…flutter#3143) * 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648) * 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963) * c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555) * ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384) * 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP for #119556
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.