Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support safe area and scrolling in the NavigationDrawer (#116995) #119555

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jan 30, 2023

CP for #119556

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

* Update navigation_drawer.dart

* Update navigation_drawer_test.dart

* Update navigation_drawer_test.dart

* update tests

* Update navigation_drawer_test.dart

* Update navigation_drawer_test.dart
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 30, 2023
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang XilaiZhang merged commit c96f14a into flutter:flutter-3.7-candidate.1 Feb 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 2, 2023
…#3143)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 3, 2023
stuartmorgan pushed a commit to flutter/plugins that referenced this pull request Feb 3, 2023
…#7091)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
…flutter#3143)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants