[release] use current branch as opposed to master #119648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
team
CaseyHillers
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
LGTM for the release branch.
In the future, prefer landing the PR In tip of tree, and then CP'ing to the release branch. Work like this is considered throwaway work, and we should minimize the amount of it we're doing. I filed #119652 to track getting it added.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 2, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 2, 2023
…#3143) * 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648) * 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963) * c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555) * ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384) * 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 3, 2023
stuartmorgan
pushed a commit
to flutter/plugins
that referenced
this pull request
Feb 3, 2023
…#7091) * 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648) * 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963) * c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555) * ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384) * 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Maatteogekko
pushed a commit
to Maatteogekko/packages
that referenced
this pull request
Feb 4, 2023
…flutter#3143) * 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648) * 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963) * c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555) * ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384) * 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: all the framework cherrypicks are blocked on customer testings this week. For example, #118963 , #119384 and Kate's PR as well.
The customer testings are failing with an exception of
bad revision of 'master', when the flutter tests repository https://github.com/flutter/tests is checked out. The command would have worked if main is checked out.As pointed out by Godofredo, instead of hard coding a master or a main branch, we will use the current branch after the git repo is cloned. Therefore the revision will be always valid.