Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removes single window assumptions from flutter_test" #122037

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

pdblasi-google
Copy link
Contributor

Reverts #121549

This appears to have caused many web tests to fail, not yet sure of underlying cause.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 6, 2023
@pdblasi-google pdblasi-google added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 6, 2023
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2023

Validation of the revert request has failed. Verify the files in the revert request are the same as the original PR and resubmit the revert request.

@thkim1011 thkim1011 merged commit a53105d into master Mar 6, 2023
@thkim1011 thkim1011 deleted the revert-121549-issues/117481 branch March 6, 2023 19:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants