-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes single window assumptions from flutter_test
#121549
Conversation
613cb7e
to
b1746bd
Compare
aafe2ad
to
20a5f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty nicely!
Oh, one more thing: I seemed to recall that we considered whether we should auto-reset the testvalues on the TestFlutterView (and ideally TestFlutterPlatformDispatcher) between tests. Did you decide against doing that or did I just miss it? |
I plan on doing that work in a separate PR. I want to do a revamp of how the |
1beddef
to
18abbb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Adds `TestFlutterView` to wrap `FlutterView` and allow modification of properties for testing * Updates `TestPlatformDispatcher` to wrap its views in `TestFlutterView`s when they are changed * Adds `viewOf` to `WidgetController` for finding a `TestFlutterView` related to the results of a `Finder` * Exposes `platformDispatcher` and `view` from `WidgetController` (and `WidgetTester`) * This is so the related `viewOf` method, which uses the `Finder` API, will be in a consistent place with these methods and other `Finder` APIs
983a652
to
10eafc3
Compare
This reverts commit f2dd19d.
@override | ||
ui.FrameData get frameData => _platformDispatcher.frameData; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the accidental deletion of this getter caused b/272195069.
TestFlutterView
to wrapFlutterView
and allow modification of properties for testingTestPlatformDispatcher
to wrap its views inTestFlutterView
s when they are changedviewOf
toWidgetController
for finding aTestFlutterView
related to the results of aFinder
platformDispatcher
andimplicitView
fromWidgetController
(andWidgetTester
)viewOf
method, which uses theFinder
API, will be in a consistent place with these methods and otherFinder
APIsResolves #117481
Pre-launch Checklist
///
).