Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement : removed required kotlin dependency #125002

Merged
merged 5 commits into from May 5, 2023
Merged

improvement : removed required kotlin dependency #125002

merged 5 commits into from May 5, 2023

Conversation

albertoazinar
Copy link
Contributor

This PR removed the non-necessary required Koltin dependency. This is because the Kotlin Gradle adds the dependency on the standard library automatically.

Fixes #98212

*If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy. *

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 17, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@andrewkolos andrewkolos self-requested a review April 27, 2023 01:17
andrewkolos
andrewkolos approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will wait for a second review from @christopherfujino before asking for a test exemption.

@christopherfujino
Copy link
Member

@reidbaker can you give final approval on this one?

@christopherfujino christopherfujino removed their request for review April 27, 2023 20:59
@reidbaker
Copy link
Contributor

Before we can approve we need the CLA signed for all contributors.

For context starting at this commit ~2 years ago we default to a version of kotlin that according to the linked documentation does not need the template version.

@reidbaker reidbaker self-requested a review April 27, 2023 23:45
reidbaker
reidbaker requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need cla

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2023
@albertoazinar
Copy link
Contributor Author

Hello @christopherfujino and @reidbaker
Is there something else I need to do?

@reidbaker
Copy link
Contributor

reidbaker commented May 5, 2023 •
edited

Hello @christopherfujino and @reidbaker
Is there something else I need to do?

I don't think so, the auto submit should run when the tree is green.

@albertoazinar
Copy link
Contributor Author

Hello @christopherfujino and @reidbaker
Is there something else I need to do?

I don't think so auto submit should run when the tree is green

Understood.
Thank you @reidbaker

@reidbaker reidbaker mentioned this pull request May 5, 2023
Closed
@reidbaker
Copy link
Contributor

Hello @christopherfujino and @reidbaker
Is there something else I need to do?

I don't think so auto submit should run when the tree is green

Understood. Thank you @reidbaker

Google testing state was stuck. Updated #125994 where this happened to another teammate and manually set the status.

@auto-submit auto-submit bot merged commit 4d4b3cf into flutter:master May 5, 2023
35 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
4d4b3cf2f improvement : removed required kotlin dependency (flutter/f…
0dc836b 
…lutter#125002)
tarrinneal pushed a commit to flutter/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (#…
07e0930 
…3922)

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@0b65723...43ac23b

2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 98486346+lindsaypj@users.noreply.github.com Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 47866232+chunhtai@users.noreply.github.com Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 jacksongardner@google.com Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 mdebbar@google.com [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
@albertoazinar
Copy link
Contributor Author

Hello @christopherfujino and @reidbaker
Is there something else I need to do?

I don't think so auto submit should run when the tree is green

Understood. Thank you @reidbaker

Google testing state was stuck. Updated #125994 where this happened to another teammate and manually set the status.

Understood. thanks for your collaboration! @christopherfujino and @reidbaker

nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (f…
3d40882 
…lutter#3922)

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@0b65723...43ac23b

2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 98486346+lindsaypj@users.noreply.github.com Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 47866232+chunhtai@users.noreply.github.com Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 jacksongardner@google.com Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 mdebbar@google.com [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
4d4b3cf2f improvement : removed required kotlin dependency (flutter/f…
c5bb048 
…lutter#125002)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
4d4b3cf2f improvement : removed required kotlin dependency (flutter/f…
4b29218 
…lutter#125002)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
4d4b3cf2f improvement : removed required kotlin dependency (flutter/f…
347968a 
…lutter#125002)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
4d4b3cf2f improvement : removed required kotlin dependency (flutter/f…
cf964b5 
…lutter#125002)
@gmackall gmackall mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@andrewkolos andrewkolos andrewkolos approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Kotlin support library dependency no longer required
4 participants
@albertoazinar @christopherfujino @reidbaker @andrewkolos