Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ReorderableListView example with cards + cleanup existing tests #126155

Merged
merged 1 commit into from May 5, 2023
Merged

Add a ReorderableListView example with cards + cleanup existing tests #126155

merged 1 commit into from May 5, 2023

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented May 5, 2023

Description

This PR adds one ReorderableListView example to demonstrate how proxyDecorator can be used to animate cards elevation.

Capture.video.du.2023-05-05.15-12-36.mp4

For motivation, see #124729 (comment).

Related Issue

Fixes #124729

Tests

Adds 1 tests.

This PR also moves some misplaced example tests from examples/api/test/reorderable_list to examples/api/test/material/reorderable_list (and replaces two existing ones).

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels May 5, 2023
@bleroux bleroux requested a review from HansMuller May 5, 2023 14:44
HansMuller
HansMuller approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example! LGTM

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2023
@auto-submit auto-submit bot merged commit de26154 into flutter:master May 5, 2023
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
c608f1f 
…ting tests (flutter/flutter#126155)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
9f0e726 
…ting tests (flutter/flutter#126155)
@bleroux bleroux deleted the add_one_reorderable_list_view_example branch May 5, 2023 18:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
e8e123c 
…ting tests (flutter/flutter#126155)
@HansMuller HansMuller mentioned this pull request May 5, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
bb86166 
…ting tests (flutter/flutter#126155)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
773f662 
…ting tests (flutter/flutter#126155)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
cd1c1d1 
…ting tests (flutter/flutter#126155)
tarrinneal pushed a commit to flutter/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (#…
07e0930 
…3922)

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@0b65723...43ac23b

2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 98486346+lindsaypj@users.noreply.github.com Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 47866232+chunhtai@users.noreply.github.com Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 jacksongardner@google.com Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 mdebbar@google.com [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (f…
3d40882 
…lutter#3922)

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@0b65723...43ac23b

2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 98486346+lindsaypj@users.noreply.github.com Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 47866232+chunhtai@users.noreply.github.com Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 jacksongardner@google.com Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 mdebbar@google.com [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
2f6b25a 
…ting tests (flutter/flutter#126155)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
b313971 
…ting tests (flutter/flutter#126155)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
f1ffe3d 
…ting tests (flutter/flutter#126155)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
de2615462 Add a ReorderableListView example with cards + cleanup exis…
ee29a81 
…ting tests (flutter/flutter#126155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReorderableListView of Cards doesn't work as it should
2 participants
@bleroux @HansMuller