Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect assert hint in flutter.groovy #125283

Merged
merged 1 commit into from May 5, 2023
Merged

Fix incorrect assert hint in flutter.groovy #125283

merged 1 commit into from May 5, 2023

Conversation

b7woreo
Copy link
Contributor

@b7woreo b7woreo commented Apr 21, 2023 •
edited

When I include flutter in my exist android project by include_flutter.groovy, it hint me:

Project :app doesn't exist. To custom the host app project name, set `org.gradle.project.flutter.hostAppProjectName=<project-name>` in gradle.properties.

But set org.gradle.project.flutter.hostAppProjectName has no effect, acutally need to set flutter.hostAppProjectName.

This pr is to fix this incorrect hint.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 21, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino christopherfujino added the platform-android Android applications specifically label Apr 27, 2023
@b7woreo b7woreo closed this May 4, 2023
@b7woreo b7woreo deleted the flutter_groovy branch May 4, 2023 14:07
@b7woreo b7woreo restored the flutter_groovy branch May 4, 2023 14:10
@b7woreo b7woreo reopened this May 4, 2023
@reidbaker reidbaker self-requested a review May 4, 2023 18:40
@reidbaker
Copy link
Contributor

@bartekpacia I can't request a review from you but your feedback is welcome.

@reidbaker reidbaker requested a review from camsim99 May 4, 2023 18:41
bartekpacia
bartekpacia reviewed May 4, 2023
View reviewed changes
Copy link
Member

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing:)

packages/flutter_tools/gradle/src/main/groovy/flutter.groovy Outdated Show resolved Hide resolved
@reidbaker reidbaker merged commit dbcff31 into flutter:master May 5, 2023
122 checks passed
@b7woreo b7woreo deleted the flutter_groovy branch May 6, 2023 00:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
dbcff31ed Fix incorrect assert hint in flutter.groovy (flutter/flutte…
4c86185 
…r#125283)
tarrinneal pushed a commit to flutter/packages that referenced this pull request May 6, 2023
@engine-flutter-autoroll
Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (#…
07e0930 
…3922)

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@0b65723...43ac23b

2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 98486346+lindsaypj@users.noreply.github.com Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 47866232+chunhtai@users.noreply.github.com Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 jacksongardner@google.com Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 mdebbar@google.com [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) (f…
3d40882 
…lutter#3922)

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@0b65723...43ac23b

2023-05-05 kevmoo@users.noreply.github.com targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 44755140+werainkhatri@users.noreply.github.com add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 98486346+lindsaypj@users.noreply.github.com Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 36861262+QuncCccccc@users.noreply.github.com Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 47866232+chunhtai@users.noreply.github.com Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 49291509+albertoazinar@users.noreply.github.com improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 b7woreo@gmail.com Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 kevmoo@users.noreply.github.com tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 jacksongardner@google.com Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 68919043+Istiak-Ahmed78@users.noreply.github.com Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 leroux_bruno@yahoo.fr Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 engine-flutter-autoroll@skia.org Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 102626803+drewroengoogle@users.noreply.github.com Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 mdebbar@google.com [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 tessertaha@gmail.com Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 pateltirth454@gmail.com [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 ian@hixie.ch Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 kevmoo@users.noreply.github.com tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
dbcff31ed Fix incorrect assert hint in flutter.groovy (flutter/flutte…
087dfce 
…r#125283)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
dbcff31ed Fix incorrect assert hint in flutter.groovy (flutter/flutte…
f53d7b3 
…r#125283)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
dbcff31ed Fix incorrect assert hint in flutter.groovy (flutter/flutte…
fab7c7e 
…r#125283)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
dbcff31ed Fix incorrect assert hint in flutter.groovy (flutter/flutte…
6db98bf 
…r#125283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia left review comments

@reidbaker reidbaker reidbaker approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees
No one assigned
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@b7woreo @reidbaker @bartekpacia @christopherfujino