Set template and migrate apps to iOS 12 minimum #140478

jmagman · 2023-12-20T22:09:12Z

Change templates to IPHONEOS_DEPLOYMENT_TARGET, MinimumOSVersion, and Podfile platform :ios to 12.0.
Add migrator for Podfile part to migrate platform :ios, '11.0' -> platform :ios, '12.0'
Compile with -miphoneos-version-min=12.0
Run the migrator on all example apps and integration tests.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2023-12-22T00:49:40Z

dev/integration_tests/ios_platform_view_tests/ios/Runner.xcodeproj/project.pbxproj

@@ -564,14 +564,12 @@
 				CURRENT_PROJECT_VERSION = 1;
 				GCC_C_LANGUAGE_STANDARD = gnu11;
 				GENERATE_INFOPLIST_FILE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 11.0;


PlatformViewUITests target should not be overriding the project-level target version or device family.

jmagman · 2023-12-22T00:50:24Z

examples/platform_view/ios/Runner.xcodeproj/project.pbxproj

@@ -311,7 +311,6 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				ENABLE_BITCODE = NO;
 				INFOPLIST_FILE = Runner/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 11.0;


Runner target should not be overriding the project-level target version.

jmagman · 2023-12-22T00:51:06Z

packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart

@@ -1172,7 +1172,7 @@ void main() {
      'CFBundleDisplayName': 'Awesome Gallery',
      // Will not use CFBundleName since CFBundleDisplayName is present.
      'CFBundleName': 'Awesome Gallery 2',
-      'MinimumOSVersion': '11.0',
+      'MinimumOSVersion': '17.0',


This version can be anything for the sake of the test.

jmagman · 2023-12-22T00:52:06Z

packages/flutter_tools/bin/podhelper.rb

@@ -32,7 +32,7 @@ def flutter_additional_ios_build_settings(target)
  return unless target.platform_name == :ios

  # [target.deployment_target] is a [String] formatted as "8.0".
-  inherit_deployment_target = target.deployment_target[/\d+/].to_i < 11
+  inherit_deployment_target = target.deployment_target[/\d+/].to_i < 12


Everything before this is from the auto-migrate, this is the start of the real tool change.

stuartmorgan

LGTM

vashworth

LGTM

…utter#140478)

This reverts commit acdbcad.

Reverts #140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reland #140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reland flutter#140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

…utter#140478)

Build the engine Flutter.framework against a minimum of iOS 12. Part of flutter/flutter#140474 Flutter tooling already enforcing iOS 12 on app-end: flutter/flutter#140478 See also #574

…utter#140478)

…deps (#5804) For iOS and macOS move fetch deps from explicity running `pub get` and `pod install` to instead run `flutter build x --config-only` which smartly fetches deps and lays down the required native pieces. I didn't guard it on whether certain files are present since the command already has similar guards, and runs pretty fast if the native code has already been generated. This fixes an issue where `pod install` is run before the Flutter native bits and migrations are run. Fixes issues seen in the Flutter roll #5792 (comment) ``` Running command: "pod install" in /Volumes/Work/s/w/ir/x/w/packages/packages/camera/camera_avfoundation/example/ios Analyzing dependencies [!] CocoaPods could not find compatible versions for pod "Flutter": In Podfile: Flutter (from `Flutter`) Specs satisfying the `Flutter (from `Flutter`)` dependency were found, but they required a higher minimum deployment target. [!] Automatically assigning platform `iOS` with version `11.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`. Unable to "pod install" ``` Caused by flutter/flutter#140478

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

…0822) Reverts flutter#140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

Reland flutter#140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

…0822) Reverts flutter#140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

Reland flutter#140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

…0822) Reverts flutter#140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

Reland flutter#140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

…utter#140478)

jmagman self-assigned this Dec 20, 2023

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 20, 2023

jmagman mentioned this pull request Dec 20, 2023

☂️ Increase minimum support iOS version from 11 to 12 #140474

Closed

8 tasks

jmagman force-pushed the template-12 branch from 28df9eb to efc8d0b Compare December 20, 2023 22:20

Set template and migrate apps to iOS 12 minimum

26c9a6d

jmagman force-pushed the template-12 branch from efc8d0b to 26c9a6d Compare December 21, 2023 23:52

jmagman marked this pull request as ready for review December 22, 2023 00:23

jmagman requested review from stuartmorgan and vashworth December 22, 2023 00:23

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Dec 22, 2023

Run migrators

3af066b

jmagman force-pushed the template-12 branch from 3eeffd3 to 3af066b Compare December 22, 2023 00:48

jmagman commented Dec 22, 2023

View reviewed changes

stuartmorgan approved these changes Jan 2, 2024

View reviewed changes

vashworth approved these changes Jan 2, 2024

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024

auto-submit bot merged commit acdbcad into flutter:master Jan 2, 2024
134 checks passed

jmagman deleted the template-12 branch January 2, 2024 19:42

engine-flutter-autoroll mentioned this pull request Jan 2, 2024

Manual roll Flutter from 11def8eff455 to babf0865783f (52 revisions) flutter/packages#5780

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 2, 2024

acdbcadb9 Set template and migrate apps to iOS 12 minimum (flutter/fl…

aefe114

…utter#140478)

jmagman added a commit that referenced this pull request Jan 2, 2024

Revert "Set template and migrate apps to iOS 12 minimum (#140478)"

7123f90

This reverts commit acdbcad.

jmagman mentioned this pull request Jan 2, 2024

Revert "Set template and migrate apps to iOS 12 minimum" #140820

Closed

loic-sharma added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 2, 2024

jmagman restored the template-12 branch January 2, 2024 20:47

auto-submit bot mentioned this pull request Jan 2, 2024

Reverts "Set template and migrate apps to iOS 12 minimum" #140822

Merged

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 2, 2024

auto-submit bot pushed a commit that referenced this pull request Jan 2, 2024

Revert "Set template and migrate apps to iOS 12 minimum (#140478)"

f173c61

This reverts commit acdbcad.

This was referenced Jan 2, 2024

Set template and migrate apps to iOS 12 minimum #140823

Merged

Targeting iOS 11 (Flutter default minimum) built with Xcode 15 crashes EXC_BAD_ACCESS when using the Networking framework #136060

Closed

engine-flutter-autoroll mentioned this pull request Jan 3, 2024

Manual roll Flutter from 11def8eff455 to d0f3777f2b97 (89 revisions) flutter/packages#5792

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024

acdbcadb9 Set template and migrate apps to iOS 12 minimum (flutter/fl…

c17e9ae

…utter#140478)

This was referenced Jan 3, 2024

Set ios_deployment_target to iOS 12.0 flutter/buildroot#808

Merged

[ci] Run 'flutter build --config-only for iOS and macOS during fetch deps flutter/packages#5804

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024

acdbcadb9 Set template and migrate apps to iOS 12 minimum (flutter/fl…

11422ef

…utter#140478)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

acdbcadb9 Set template and migrate apps to iOS 12 minimum (flutter/fl…

ab4fca6

…utter#140478)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set template and migrate apps to iOS 12 minimum #140478

Set template and migrate apps to iOS 12 minimum #140478

jmagman commented Dec 20, 2023 •

edited

jmagman Dec 22, 2023

jmagman Dec 22, 2023

jmagman Dec 22, 2023

jmagman Dec 22, 2023

stuartmorgan left a comment

vashworth left a comment

Set template and migrate apps to iOS 12 minimum #140478

Set template and migrate apps to iOS 12 minimum #140478

Conversation

jmagman commented Dec 20, 2023 • edited

Pre-launch Checklist

jmagman Dec 22, 2023

Choose a reason for hiding this comment

jmagman Dec 22, 2023

Choose a reason for hiding this comment

jmagman Dec 22, 2023

Choose a reason for hiding this comment

jmagman Dec 22, 2023

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

vashworth left a comment

Choose a reason for hiding this comment

jmagman commented Dec 20, 2023 •

edited