Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set template and migrate apps to iOS 12 minimum #140823

Merged
merged 3 commits into from Jan 3, 2024
Merged

Set template and migrate apps to iOS 12 minimum #140823

merged 3 commits into from Jan 3, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 2, 2024 •
edited

Reland #140478 with ios_content_validation_test test fix.

[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}
  1. Change templates to IPHONEOS_DEPLOYMENT_TARGET, MinimumOSVersion, and Podfile platform :ios to 12.0.
  2. Add migrator for Podfile part to migrate platform :ios, '11.0' -> platform :ios, '12.0'
  3. Compile with -miphoneos-version-min=12.0
  4. Run the migrator on all example apps and integration tests.

See also #62902 and #85174 and #101963

Fixes #136060

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Jan 2, 2024
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Jan 2, 2024
jmagman
jmagman commented Jan 2, 2024
View reviewed changes
dev/devicelab/bin/tasks/ios_content_validation_test.dart
@@ -48,7 +48,7 @@ Future<void> main() async {
' • Version Number: 1.0.0\n',
' • Build Number: 1\n',
' • Display Name: Hello\n',
' • Deployment Target: 11.0\n',
' • Deployment Target: 12.0\n',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line different than #140478

@jmagman jmagman requested a review from vashworth January 2, 2024 20:55
vashworth
vashworth approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@jmagman jmagman mentioned this pull request Jan 2, 2024
Closed
2 tasks
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jan 2, 2024

auto label is removed for flutter/flutter/140823, due to - The status or check suite Windows plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2024
@auto-submit auto-submit bot merged commit b08fc60 into flutter:master Jan 3, 2024
137 checks passed
@jmagman jmagman deleted the template-12 branch January 3, 2024 01:26
jmagman added a commit to jmagman/flutter that referenced this pull request Jan 3, 2024
@jmagman
Set template and migrate apps to iOS 12 minimum (flutter#140823)
86c85fe 
Reland flutter#140478 with `ios_content_validation_test` test fix.
```
[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}

```

__________

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also flutter#62902 and flutter#85174 and flutter#101963

Fixes flutter#136060
@jmagman jmagman mentioned this pull request Jan 3, 2024
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
b08fc6002 Set template and migrate apps to iOS 12 minimum (flutter/fl…
7be6503 
…utter#140823)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
b08fc6002 Set template and migrate apps to iOS 12 minimum (flutter/fl…
985d33b 
…utter#140823)
victoreronmosele pushed a commit to victoreronmosele/flutter that referenced this pull request Jan 6, 2024
@jmagman @victoreronmosele
Set template and migrate apps to iOS 12 minimum (flutter#140823)
b03097d 
Reland flutter#140478 with `ios_content_validation_test` test fix.
```
[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}

```

__________

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also flutter#62902 and flutter#85174 and flutter#101963

Fixes flutter#136060
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@jmagman @Michal-MK
Set template and migrate apps to iOS 12 minimum (flutter#140823)
94fe969 
Reland flutter#140478 with `ios_content_validation_test` test fix.
```
[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}

```

__________

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also flutter#62902 and flutter#85174 and flutter#101963

Fixes flutter#136060
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@jmagman @Markzipan
Set template and migrate apps to iOS 12 minimum (flutter#140823)
27557b1 
Reland flutter#140478 with `ios_content_validation_test` test fix.
```
[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}

```

__________

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also flutter#62902 and flutter#85174 and flutter#101963

Fixes flutter#136060
auto-submit bot pushed a commit that referenced this pull request Jan 9, 2024
@jmagman
Set template and migrate apps to iOS 12 minimum (#140921)
46787ee 
Cherry-pick #140823

Issue #140923

This looks like a lot of files, but most of them are updating the version on our integration/examples apps.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
b08fc6002 Set template and migrate apps to iOS 12 minimum (flutter/fl…
05173a2 
…utter#140823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vashworth vashworth vashworth approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
2 participants
@jmagman @vashworth