Change minimum iOS version from 8.0 to 9.0 #62902

jmagman · 2020-08-04T20:34:38Z

Description

Update create app and module templates to iOS minimum version 9.0.
Updated example projects manually. Will hold off on integration tests until know know if we can do it automatically with #62880

This does not update the plugin template podspec minimum version. To be discussed separately.

Related Issues

Fixes #60035

Tests

Updated -miphoneos-version-min calls.
App creation and example build integration tests cover part of this.

Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.

jmagman · 2020-08-05T01:11:07Z

packages/flutter_tools/templates/plugin/ios-objc.tmpl/projectName.podspec.tmpl

@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
  s.source_files = 'Classes/**/*'
  s.public_header_files = 'Classes/**/*.h'
  s.dependency 'Flutter'
-  s.platform = :ios, '8.0'
+  s.platform = :ios, '9.0'


Note these newly created plugins will not be able to be used by Flutter apps with a minimum of 8.0 (compilation time error), so that's all apps currently in the wild now.

I really wish there wasn't an error for this, or at least I wish it was suppressible.

I'm willing to be convinced we shouldn't increase the plugin minimum requirement for a few stable cycles until more apps have upgraded to 9.0...

so you're saying an app can't use a plugin with a higher minimum ios version?

Yes. I'm going to revert the plugin min version bump, it seems like we need to talk about that separately.

jmagman · 2020-08-05T01:49:09Z

packages/flutter_tools/lib/src/plugins.dart

@@ -891,7 +891,7 @@ Future<void> _writeIOSPluginRegistrant(FlutterProject project, List<Plugin> plug
  final List<Map<String, dynamic>> iosPlugins = _extractPlatformMaps(plugins, IOSPlugin.kConfigKey);
  final Map<String, dynamic> context = <String, dynamic>{
    'os': 'ios',
-    'deploymentTarget': '8.0',
+    'deploymentTarget': '9.0',


This is not used for published plugins, it's generated for app and modules that need to import plugins.

christopherfujino

LGTM

xster · 2020-08-05T19:56:23Z

This means we're intentionally not changing ios_workflow in this PR?

jmagman · 2020-08-05T21:31:42Z

This means we're intentionally not changing ios_workflow in this PR?

This PR is to prevent the "IPHONEOS_DEPLOYMENT_TARGET too low" warning that happens when you target 8.0 in Xcode 14.

Are you think of #62883 maybe?

xster · 2020-08-06T19:13:34Z

Yes, my comment makes no sense :D
Please disregard. LGTM

PiN73 · 2020-10-20T21:44:07Z

As it breaks building of existing apps for iOS (see issue), there should be a notice in breaking changes page saying to modify ios project, shouldn't it?

PiN73 · 2020-10-20T22:44:15Z

Also if I understood correctly, Flutter now supports iOS 9.0 and later, not 8.0 as before, this should be fixed at Build and release an iOS app page

jmagman · 2020-10-21T02:09:36Z

@PiN73 Flutter supports iOS 8, but the default for a new app is now iOS 9 to avoid Xcode 12 warnings.

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reverts #140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reland #140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also #62902 and #85174 and #101963 Fixes #136060

Reland flutter#140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also flutter#62902 and flutter#85174 and flutter#101963 Fixes flutter#136060

Change minimum iOS version from 8.0 to 9.0

3d09d63

flutter-dashboard bot added d: examples Sample code and demos team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Aug 4, 2020

jmagman self-assigned this Aug 4, 2020

jmagman commented Aug 5, 2020

View reviewed changes

jmagman removed the work in progress; do not review label Aug 5, 2020

jmagman marked this pull request as ready for review August 5, 2020 01:11

jmagman requested review from xster and christopherfujino August 5, 2020 01:11

Revert plugin min version bump

d2aaa3f

jmagman commented Aug 5, 2020

View reviewed changes

christopherfujino approved these changes Aug 5, 2020

View reviewed changes

zanderso added the waiting for tree to go green label Aug 6, 2020

fluttergithubbot merged commit 0aafdf9 into flutter:master Aug 6, 2020

jmagman deleted the ios-9 branch August 7, 2020 19:02

This was referenced Aug 11, 2020

[google_maps_flutter] Pin GoogleMaps cocoapod dep to last good known version flutter/plugins#2924

Merged

module_test_ios fails, Undefined symbols for architecture armv7: "_OBJC_CLASS_$_UIPointerShape", referenced from: objc-class-ref in GoogleMaps #63447

Closed

jmagman added the platform-ios iOS applications specifically label Aug 21, 2020

TahaTesser mentioned this pull request Aug 21, 2020

Flutter apps crash on launch on iOS 8, MetalKit image not found #64017

Closed

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Change minimum iOS version from 8.0 to 9.0 (flutter#62902)

6c018cf

jmagman restored the ios-9 branch October 21, 2020 17:55

jmagman deleted the ios-9 branch October 21, 2020 17:56

This was referenced Oct 21, 2020

App.framework must support iOS 8 for older Flutter projects #68729

Merged

App Store iOS submission fails: The bundle Runner.app/Frameworks/App.framework does not support the minimum OS Version specified in the Info.plist #58200

Closed

tneotia mentioned this pull request Jan 24, 2021

Switch from chewie_audio to asset_audio_player Sub6Resources/flutter_html#509

Closed

jmagman mentioned this pull request Mar 4, 2021

Updating new plugin's min iOS sdk to 9.0 #77275

Closed

8 tasks

jmagman mentioned this pull request Jun 24, 2021

Migrate iOS app deployment target from 8.0 to 9.0 #85174

Merged

This was referenced Jul 21, 2021

Update iOS minimum version to 9.0 flutter/website#6057

Merged

Increase Flutter framework minimum iOS version to 9.0 #86840

Merged

Documentation re: iOS 9 minimum version #62879

Closed

jmagman mentioned this pull request Sep 8, 2021

Increase integration_test package minimum iOS version to 9.0 #89621

Merged

jmagman mentioned this pull request Oct 11, 2021

Build arm64 during Mac Host Engine build #84453

Closed

This was referenced Apr 15, 2022

☂️ Increase minimum support iOS version from 9 to 11 #101959

Closed

Increase app minimum supported iOS version from 9.0 to 11.0 #101960

Closed

Set template and migrate apps to iOS 11 minimum #101963

Merged

jmagman mentioned this pull request Dec 20, 2023

Set template and migrate apps to iOS 12 minimum #140478

Merged

8 tasks

auto-submit bot mentioned this pull request Jan 2, 2024

Reverts "Set template and migrate apps to iOS 12 minimum" #140822

Merged

8 tasks

jmagman mentioned this pull request Jan 2, 2024

Set template and migrate apps to iOS 12 minimum #140823

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change minimum iOS version from 8.0 to 9.0 #62902

Change minimum iOS version from 8.0 to 9.0 #62902

jmagman commented Aug 4, 2020 •

edited

Loading

jmagman Aug 5, 2020

christopherfujino Aug 5, 2020

jmagman Aug 5, 2020

christopherfujino Aug 5, 2020

jmagman Aug 5, 2020

christopherfujino left a comment

xster commented Aug 5, 2020

jmagman commented Aug 5, 2020

xster commented Aug 6, 2020

PiN73 commented Oct 20, 2020

PiN73 commented Oct 20, 2020

jmagman commented Oct 21, 2020

Change minimum iOS version from 8.0 to 9.0 #62902

Change minimum iOS version from 8.0 to 9.0 #62902

Conversation

jmagman commented Aug 4, 2020 • edited Loading

Description

Related Issues

Tests

Checklist

Breaking Change

jmagman Aug 5, 2020

Choose a reason for hiding this comment

christopherfujino Aug 5, 2020

Choose a reason for hiding this comment

jmagman Aug 5, 2020

Choose a reason for hiding this comment

christopherfujino Aug 5, 2020

Choose a reason for hiding this comment

jmagman Aug 5, 2020

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

xster commented Aug 5, 2020

jmagman commented Aug 5, 2020

xster commented Aug 6, 2020

PiN73 commented Oct 20, 2020

PiN73 commented Oct 20, 2020

jmagman commented Oct 21, 2020

jmagman commented Aug 4, 2020 •

edited

Loading