Update Regex to retrieve PRODUCT_BUNDLE_IDENTIFIER without quote mark if there are any (#21335) #22667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if there are any (#21335)
|
The check failed due to a timeout... should I repost this pull request? |
* Adding Changelog URL to the README.md file * Update README to match the latest version on DEV - Update README to match the latest version on DEV branch - Add Changelog URL * Update README.md Fix contributing link
Previously flutter_tools had used "gradle properties" to find the build types and flavors supported by the Gradle project. Tasks should work more reliably across different versions of the Android Gradle plugin. Fixes #20781
* Vertical divider bug fix and additional cleaning.
git log 7e3b41d..74e68ff --no-merges --oneline 74e68ff Roll src/third_party/skia 7b7805581733..66a973493468 (4 commits) (#6436) 58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (#6435) 83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (#6434) 5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (#6432) 5340f42 Revert "Use single_root_scheme when compiling platform (#6402)" (#6431) 37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (#6419) 4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (#6429) 165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (#6427) 34bd0ef Don’t build benchmarking binaries on Windows. (#6428) ae4db44 Ensure setViewIdResourceName has the correct version guard (#6404) 2c5d0c4 [rapidjson] Fix import statements (#6418) c2128fc Create a benchmarking target for the shell. (#6420) 30f78af Raise errors on non-zero exits while creating artifacts on the bots. (#6424) 191168c Disable line_height tests on Windows (#6423) 061cc66 Fix ideographic baseline to match spec. (#6422) 74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (#6421) 10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (#6417)
flutter/engine@74e68ff...c8755d7 git log 74e68ff..c8755d7 --no-merges --oneline c8755d7 Update FlutterFrontendCompiler.rejectLastDelta to match the signature in CompilerInterface (flutter/engine#6426) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This renames the "module" template to the "application" template, and makes "application" the default. The existing "app" template is now deprecated. flutter create also now recognizes the type of project in an existing directory, and is able to recreate it without having the template type explicitly specified (although you can still do that). It does this now by first looking in the .metadata file for the new project_type field, and if it doesn't find that, then it looks at the directory structure. Also, the .metadata file is now overwritten even on an existing directory so that 1) the project_type can be added to legacy projects, and 2) the version of Flutter that updated the project last is updated. I also cleaned up a bunch of things in create_test.dart, added many more tests, and added an example test to the test/ directory in the generated output of the application template. Fixes #22530 Fixes #22344
Fixes the build after my module rename broke the Windows tests.
#22676) Apparently, this accounts for 13% of our crashes in Beta.
The Gallery deployment was missing some secrets in order to correctly deploy. This adds those missing secrets as encrypted env vars.
flutter/engine@c8755d7...45c5fe5 git log c8755d7..45c5fe5 --no-merges --oneline 45c5fe5 Remove touch mapper and respect the UITouch phase when calculating the pointer data change type. (flutter/engine#6430) 2347368 Roll src/third_party/skia 66a973493468..d95303e10cbc (13 commits) (flutter/engine#6440) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This reverts commit fef759f, because apparently the service is still "unavailable".
flutter/engine@45c5fe5...cf0855e git log 45c5fe5..cf0855e --no-merges --oneline cf0855e Roll Dart to version c6254163dc7a5f704d7609af65e4650ef0550ccd (flutter/engine#6439) 2fa1ab9 Roll src/third_party/skia d95303e10cbc..4302eb9a6e14 (12 commits) (flutter/engine#6443) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
flutter/engine@cf0855e...90b1023 git log cf0855e..90b1023 --no-merges --oneline 90b1023 Remove unused imports and variables (flutter/engine#6437) 1f98aa6 Add the isolate name server to the set of native APIs available on secondary isolates (flutter/engine#6444) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
#22338 (comment) shows almost 1 minute being spent on the `Resolving Dependencies` step alone. Possibly this needs to go higher still, but this should be a good start.
* [frdp] Add optional dart isolate filter. It's now default to filter out non-flutter isolates when searching across Dart VM's. This is due to a possible issue wherein an Isolate for testing might have the same name as the flutter Isolate. In addition, logging messages have been added in dart_vm.dart for debugging.
flutter/engine@90b1023...4eaf9ef git log 90b1023..4eaf9ef --no-merges --oneline 4eaf9ef Roll src/third_party/skia a6262495da48..032f2756df64 (2 commits) (flutter/engine#6450) c5e52dc Roll src/third_party/skia 92d10833de63..a6262495da48 (1 commits) (flutter/engine#6449) efb24f1 Roll src/third_party/skia 4f87e2255b8a..92d10833de63 (2 commits) (flutter/engine#6448) 28e5136 Roll src/third_party/skia d945698c5dfa..4f87e2255b8a (2 commits) (flutter/engine#6446) a2ea59f Roll src/third_party/skia 4302eb9a6e14..d945698c5dfa (4 commits) (flutter/engine#6445) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
* [Documentation] Moved lerp macro def to painting/
* updated comment
…o doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
A few changes: * Remove the search tip (it relies on searching for the new keyword which we no longer use) * Remove mentioning of examples that are either stale or only used for internal purposes (such as test) * Cross-link to the samples repo
Fixes a gradle error where it was failing to find a plugin because of an absolute path in the .flutter-plugins file instead of a relative path. I had originally removed this variable because I thought it was redundant with the projectDir, but apparently I was wrong about that (one resolves to a relative path, and one resolves to an absolute path). This PR reverts that part of the change and reintroduces the (not really) redundant variable.
* Adds comments clarifying the procedure used to render the menu as well as tests verifying various dropdown menu button positioning and initial scroll states.
Adds a Fuchsia compatibility function that allows for connecting to a specific Isolate by name when running Flutter Driver on a Fuchsia device. This will check over multiple Dart VM's in an attempt to find an Isolate by its name.
Obviously a small change, looks like a little copy-paste accident.
* [Typo] it it -> if it
We'll roll this back as soon as the Dart analyzer gets upgraded in Google3.
* Refactor AnimatedSwitcher This is mostly just a little bit of cleanup with hopefully no semantic changes, done to teach me how the code works so that I could fix a bug. * Add debugging information to AnimatedSwitcher * Fix AnimatedSwitcher to handle the case of back-to-back changes Previously, if a child was replaced the very next frame after it was added, we'd get confused because we tried to reverse the controller, which causes us to remove the child from the going-away list, before we had added the child to the list in the first place. The fix is just to move the reverse to after the add.
Publish make-host-app-editable command with CLI docs.
flutter/engine@572fa56...88facf4 git log 572fa56..88facf4 --no-merges --oneline 88facf4 Roll src/third_party/skia 8ad991da4c04..00de965d0d31 (6 commits) (flutter/engine#6467) 647302a Correct issues in visible children determination (flutter/engine#6455) 0052733 Roll src/third_party/skia 95320ee01f5b..8ad991da4c04 (1 commits) (flutter/engine#6465) 7decce2 Roll src/third_party/skia 9aa3f9095622..95320ee01f5b (1 commits) (flutter/engine#6463) 2667780 Roll src/third_party/skia beb1559bc61f..9aa3f9095622 (1 commits) (flutter/engine#6462) 5d28dce Roll src/third_party/skia e9b61ef5aa34..beb1559bc61f (1 commits) (flutter/engine#6460) 54b709d Roll src/third_party/skia 71143d6cc039..e9b61ef5aa34 (1 commits) (flutter/engine#6459) 9fc5013 Roll src/third_party/skia 623d2e4120c2..71143d6cc039 (1 commits) (flutter/engine#6458) 841454c Roll src/third_party/skia 29b11d605f25..623d2e4120c2 (1 commits) (flutter/engine#6457) 5331df8 Roll src/third_party/skia d037f4d204c2..29b11d605f25 (1 commits) (flutter/engine#6456) 6d4de7f Roll src/third_party/skia 51c89e41c05b..d037f4d204c2 (9 commits) (flutter/engine#6454) ba9b907 Add `run_tests.sh` to cirrus (flutter/engine#6441) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
flutter/engine@88facf4...7ecc879 git log 88facf4..7ecc879 --no-merges --oneline 7ecc879 Fix failing test on Cirrus (flutter/engine#6469) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
flutter/engine@7ecc879...bfcdad8 git log 7ecc879..bfcdad8 --no-merges --oneline bfcdad8 Roll src/third_party/skia 00de965d0d31..9b7bfd09106f (11 commits) (flutter/engine#6471) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
…ote mark if there are any (#21335)" This reverts commit e68594c9444e6ae4b9443700e719175c9143b06c.
… if there are any (#21335)
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Closing and recreating pull request |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.