don't warn for non-matching device discoverers #25440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoechi
added
the
tool
|
This is probably good to remove, since there is no real external workflow for fuchsia that doesn't involve the full source tree. Also for example, if we build in support for hummingbird and or the desktop platforms, it would probably be more difficult to tell what the devices are the user really intends to target. |
tvolkert
approved these changes
Dec 17, 2018
keertip
approved these changes
Dec 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a warning if we have a device discoverer that does support the current platform, but can't currently list devices. This produces a warning in IDEs that users can't do anything about. A better mechanism is to point people to flutter doctor, which can have more nuances in its output.
@jonahwilliams @keertip