Add basic web device and run support #28302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoechi
added
the
tool
|
For windows, I believe the command is as simple as |
|
friendly ping @yjbanov |
yjbanov
approved these changes
Feb 26, 2019
|
|
||
| Future<void> ensureReadyForPlatformSpecificTooling() async { | ||
| /// Generate index.html in build/web. Eventually we could support | ||
| /// a custom html under the web sub directory. |
There was a problem hiding this comment.
FWIW internally we already switched to hand-written index.html. We consider it equivalent of Java/ObjC code generated by flutter create then edited by hand.
There was a problem hiding this comment.
Makes sense, we can generate the index.html only as a part of flutter create and then separate out the generatedPluginRegistry files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a skeleton web device, web specific project, and support for run via
--release --no-hot. This device exists behind the FLUTTER_WEB env variable to prevent breaking default flutter run until we decide on the UX there. Added ability to launch chrome on mac.Related Issues
Fixes #28288
Fixes #28287
Part of #28285
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?