Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache location, artifacts, and re-enable dart2js test #29783

Merged
merged 4 commits into from
Mar 26, 2019

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 22, 2019

Description

Use the new location for dart2js, kernel-worker, web sdk. Re-enable web tests

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@jonahwilliams jonahwilliams added tool Affects the "flutter" command-line tool. See also t: labels. and removed cla: yes labels Mar 22, 2019
@jonahwilliams
Copy link
Member Author

Note: the tests are expected to fail until the next engine roll

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/flutter_tools/lib/src/cache.dart Show resolved Hide resolved
@jonahwilliams jonahwilliams merged commit 44b22c7 into flutter:master Mar 26, 2019
@jonahwilliams jonahwilliams deleted the dart2js_test_enable branch March 26, 2019 01:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants