Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace no-op log reader with real implementation #31526

Merged
merged 6 commits into from
Apr 24, 2019
Merged

replace no-op log reader with real implementation #31526

merged 6 commits into from
Apr 24, 2019

Conversation

jonahwilliams
Copy link
Member

Description

Replace no-op log reader and share implementation across desktop platforms.

Related Issues

Fixes #31521

stuartmorgan
stuartmorgan approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kf6gpe kf6gpe added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 23, 2019
@jonahwilliams jonahwilliams merged commit 15ba395 into flutter:master Apr 24, 2019
@jonahwilliams jonahwilliams deleted the fix_desktop_log_reader branch April 24, 2019 00:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'flutter run' on desktop is not showing stdout/stderr
4 participants
@jonahwilliams @stuartmorgan @kf6gpe @googlebot