-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure resident web runner usage to avoid SDK users that don't support dwds #37815
Restructure resident web runner usage to avoid SDK users that don't support dwds #37815
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Codecov Report
@@ Coverage Diff @@
## master #37815 +/- ##
=========================================
+ Coverage 55.52% 55.72% +0.2%
=========================================
Files 193 194 +1
Lines 18168 18172 +4
=========================================
+ Hits 10087 10127 +40
+ Misses 8081 8045 -36
Continue to review full report at Codecov.
|
…tter into restructure_of_imports
cc @yjbanov PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the messages are not confusing to non-google3 users, let's refer to it as "SDK users that don't support dwds" in the PR description and comments.
Description
dwds doesn't exist in google3, which means I'll need to restructure the code so we can exclude it from the internal tool. To avoid a revert/reland/revert cycle I can remove the imports for now