roll ios-deploy version to 2fbbee77ea2b3212959b9dddda816f59094cd7cd #40398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherfujino
added
the
tool
tvolkert
pushed a commit
to tvolkert/flutter
that referenced
this pull request
Sep 24, 2019
Merged
tvolkert
added a commit
that referenced
this pull request
Sep 24, 2019
roll ios-deploy version to 2fbbee77ea2b3212959b9dddda816f59094cd7cd (#40398)
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to pick up an upstream fix to ios-control/ios-deploy#385 which was causing #37699
This brings us up to here 2fbbee77ea2b3212959b9dddda816f59094cd7cd, which confusingly, is equivalent to a6e61f44a9d7bcf5a70ad157d5128f5fa229272a upstream. This is because I forked our mirror to include include more comprehensive LICENSE files, but then I later upstreamed this change, and thus I had to merge the two. Moving forward the git hashes of our mirror should be the same as the upstream hashes.
Related Issues
Partially fixes this, although another PR will be necessary to fix another cause #37699