-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fluter tool usage of protobuf #40410
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40410 +/- ##
==========================================
+ Coverage 59.59% 59.6% +0.01%
==========================================
Files 192 191 -1
Lines 18602 18572 -30
==========================================
- Hits 11086 11070 -16
+ Misses 7516 7502 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ question
@@ -38,7 +38,6 @@ dependencies: | |||
yaml: 2.1.16 | |||
flutter_goldens_client: | |||
path: ../flutter_goldens_client | |||
protobuf: 0.13.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need to be removed from the BUILD.gn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We technically still depend on this transitively...I'm not sure. I'd rather leave it in to be safe
Description
It looks protobuf is going to have some upcoming breaking changes. I don't want to deal with these, so instead I'll just switch back to JSON.