Re-Re-land Implement flutter build bundle with assemble #41230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bundle_assemble
…to bundle_assemble
…to bundle_assemble
fluttergithubbot
added
team
jonahwilliams
commented
Sep 24, 2019
| @@ -84,8 +84,6 @@ abstract class CodegenDaemon { | |||
| /// Only a subset of the arguments provided to the [KernelCompiler] are | |||
| /// supported here. Using the build pipeline implies a fixed multiroot | |||
| /// filesystem and requires a pubspec. | |||
| /// | |||
There was a problem hiding this comment.
Unrelated change, but stale comment should be safe to delete...
jonahwilliams
commented
Sep 24, 2019
| @@ -123,7 +123,7 @@ class FileHashStore { | |||
| printTrace('Persisting file store'); | |||
| final File file = _cacheFile; | |||
| if (!file.existsSync()) { | |||
| file.createSync(); | |||
| file.createSync(recursive: true); | |||
There was a problem hiding this comment.
If the parent directory was missing this crashed with a missing file exception. The test added below exercises this case
jmagman
approved these changes
Sep 25, 2019
jonahwilliams
added a commit
that referenced
this pull request
Sep 25, 2019
…)" This reverts commit 84a476a.
jonahwilliams
added a commit
that referenced
this pull request
Sep 25, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reland fixes issues introduced when adjusting invalidation of the file hashes. An additional test case has been added which confirms that if the filecache is deleted we no longer crash.