-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Devicelab README with new dashboard information #48908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@Hixie this removes the legacy devicelab images, and removes them from the grandfathered binary check. Is this okay? If so, how do I update the value for https://github.com/flutter/flutter/blob/master/dev/bots/analyze.dart#L1059? I am not able to convert its value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Its 0xC8B950A9690274D3 |
Thanks Jonah! |
6efd103
to
a8db56d
Compare
I forgot this was opened. I am going to submit this since this only removes binaries, and does not add any. |
Description
Add links to the different pages on the build dashboard. Update the color coding scheme for tasks.
Add the current list of capabilities the devicelab supports.
Remove old dashboard images
Related Issues
#43095 updated the build dashboard to the version written in Flutter.
Tests
No tests added since this just updates the documentation.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.