Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Devicelab README with new dashboard information #48908

Merged
merged 8 commits into from
Feb 12, 2020

Conversation

CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Jan 15, 2020

Description

Add links to the different pages on the build dashboard. Update the color coding scheme for tasks.

Add the current list of capabilities the devicelab supports.

Remove old dashboard images

Related Issues

#43095 updated the build dashboard to the version written in Flutter.

Tests

No tests added since this just updates the documentation.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jan 15, 2020
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CaseyHillers
Copy link
Contributor Author

@Hixie this removes the legacy devicelab images, and removes them from the grandfathered binary check. Is this okay? If so, how do I update the value for https://github.com/flutter/flutter/blob/master/dev/bots/analyze.dart#L1059?

I am not able to convert its value of -3983063706891029293 to the correct hexadecimal value.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Member

Its 0xC8B950A9690274D3

@CaseyHillers
Copy link
Contributor Author

Thanks Jonah!

@CaseyHillers
Copy link
Contributor Author

I forgot this was opened. I am going to submit this since this only removes binaries, and does not add any.

@CaseyHillers CaseyHillers merged commit 781cd4d into flutter:master Feb 12, 2020
@CaseyHillers CaseyHillers deleted the devicelab branch February 12, 2020 02:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants