Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] resolve requests to web directory in debug mode #51995

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

jonahwilliams
Copy link
Member

Description

Ensure requests to files in the web directory are resolved in debug mode.

Fixes #51985

@fluttergithubbot fluttergithubbot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 5, 2020

import 'dart:html' as html;

Future<void> main() async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brief explanation about how this test attempts to reproduce the use-case would be useful to future readers of this code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jonahwilliams
Copy link
Member Author

The failing test is fixed at master and is unrelated to this PR

@jonahwilliams jonahwilliams merged commit bbf913b into flutter:master Mar 5, 2020
@jonahwilliams jonahwilliams deleted the serve_js_web_dir branch March 5, 2020 20:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter Web and <script src="file.js"></script> in the index.html?
4 participants