Only fetch tags when not on dev/beta/stable #53450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
christopherfujino
approved these changes
Mar 28, 2020
| @@ -722,7 +722,12 @@ class GitTagVersion { | |||
|
|
|||
| static GitTagVersion determine(ProcessUtils processUtils, {String workingDirectory, bool fetchTags = false}) { | |||
| if (fetchTags) { | |||
| _runGit('git fetch $_flutterGit --tags', processUtils, workingDirectory); | |||
| final String channel = _runGit('git rev-parse --abbrev-ref HEAD', processUtils, workingDirectory); | |||
There was a problem hiding this comment.
nit. can you use the channel getter from here https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/version.dart#L111
There was a problem hiding this comment.
I can't because instantiating that type calls this method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch avoids doing git tag fetches when determining the git version on stable/beta/dev. This way we still fetch tags on random developer branches and on master, where the tag has a bigger impact on the version and may have gotten messed up due to whatever workflow the developer used to checkout their branch, but does not use network bandwidth unnecessarily for most users.
Related Issues
Discussion at #52250
Tests
I added the following tests:
Test that we fetch the tags on master, but not on dev.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.I did all the things.