Swap xcodeproj_tests from MockProcessManager to FakeProcessManager #56505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
team
jmagman
commented
May 7, 2020
| command: <String>[ | ||
| xcodebuild, | ||
| '-project', | ||
| fileSystem.path.separator, |
There was a problem hiding this comment.
This was the test that should have failed but didn't.
platform.pathSeparator is null, fileSystem.path.separator is / but this processManager runSync was never being verified.
jonahwilliams
approved these changes
May 7, 2020
| flakes: 1, | ||
| delay: delay + const Duration(seconds: 1), | ||
| ); | ||
| platform.environment = Map<String, String>.unmodifiable(<String, String>{}); |
There was a problem hiding this comment.
const <String, String>{} will also create an unmodifiable map
| '-project', | ||
| '/', | ||
| '-target', | ||
| '', |
There was a problem hiding this comment.
This line is odd ... is this a stray empty string or are we default to '' for some unset value?
There was a problem hiding this comment.
The second parameter in await xcodeProjectInterpreter.getBuildSettings('', '') is the target, and it's just trusting that input as the target name. I can make it Runner or something more obvious.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change most of the xcodeproj_tests from MockProcessManager to FakeProcessManager. I had to keep MockProcessManager for the one test that needed to throw on run to work around #56415, and another that was using the
flakyProcessFactory.Related Issues
I started working on #56489 and none of the tests in this file that should have been failing were doing so. Used the FakeProcessManager to spot the calls that weren't being verified with the right parameters.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change