[flutter_tools] even more test fixes #60156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
jonahwilliams
commented
Jun 24, 2020
| @@ -25,6 +26,8 @@ void main() { | |||
| final List<Device> devices = <Device>[device1, device2, device3]; | |||
| final DeviceManager deviceManager = TestDeviceManager(devices); | |||
| expect(await deviceManager.getDevices(), devices); | |||
| }, overrides: <Type, Generator>{ | |||
| Artifacts: () => Artifacts.test(), | |||
There was a problem hiding this comment.
Hitting real artifacts, failing if they did not exist
jonahwilliams
commented
Jun 24, 2020
| @@ -791,28 +792,36 @@ void main() { | |||
| }); | |||
|
|
|||
| testUsingContext('Correct flutter runner', () async { | |||
| expect(globals.artifacts.getArtifactPath( | |||
| final MockCache cache = MockCache(); | |||
There was a problem hiding this comment.
Hitting real cache, failing if it didn't exist.
jonahwilliams
commented
Jun 24, 2020
| }); | ||
|
|
||
| testUsingContext('Does not hot restart when device does not support it', () async { | ||
| fileSystem.file(globalPackagesPath) |
There was a problem hiding this comment.
hitting real file system, failing if a .packages didn't exist
jonahwilliams
commented
Jun 24, 2020
| @@ -52,7 +51,6 @@ void main() { | |||
|
|
|||
| String podsIsInCustomDir({String cocoapodsReposDir}) { | |||
| cocoapodsReposDir ??= fileSystem.path.join( | |||
| globals.fsUtils.homeDirPath, | |||
There was a problem hiding this comment.
This test apparently doesn't rely on this value, avoid looking up potentially null home dir path
jonahwilliams
commented
Jun 24, 2020
| @@ -43,7 +43,9 @@ void main() { | |||
| MockHttpServer mockHttpServer; | |||
|
|
|||
| setUpAll(() async { | |||
| packages = await loadPackageConfigUri(Uri.base.resolve('.packages')); | |||
| packages = PackageConfig(<Package>[ | |||
There was a problem hiding this comment.
This fails if .packages doesn't exist
jmagman
approved these changes
Jun 24, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Fix tests broken under tester
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix tests broken under tester