Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] update device discovery constructors #61640

Merged
merged 6 commits into from
Jul 28, 2020
Merged

[flutter_tools] update device discovery constructors #61640

merged 6 commits into from
Jul 28, 2020

Conversation

jonahwilliams
Copy link
Member

Description

google3 callsites are updated, remove global lookup from constructor parameters.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 16, 2020
jmagman
jmagman reviewed Jul 16, 2020
View reviewed changes
packages/flutter_tools/test/general.shard/android/android_device_discovery_test.dart Outdated
@@ -26,6 +26,8 @@ void main() {
featureFlags: TestFeatureFlags(),
),
processManager: FakeProcessManager.list(<FakeCommand>[]),
fileSystem: MemoryFileSystem.test(),
platform: FakePlaatform(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FakePlaatform has a typoo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaanks!

jmagman
jmagman approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Jul 17, 2020

google3_doctor.dart is sad:

  The parameter 'platform' is required. #missing_required_param
  The parameter 'iosWorkflow' is required. #missing_required_param
  The parameter 'logger' is required. #missing_required_param
  The parameter 'xcdevice' is required. #missing_required_param

@jonahwilliams
Copy link
Member Author

Fixing google3 here: cl/322401679

@jonahwilliams
Copy link
Member Author

google3 testing either passed or failed to run :)

@jonahwilliams jonahwilliams merged commit 59e0a2e into flutter:master Jul 28, 2020
@jonahwilliams jonahwilliams deleted the cleanup_constructors branch July 28, 2020 17:21
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@jonahwilliams @Pragya007
[flutter_tools] update device discovery constructors (flutter#61640)
94520f4 
google3 callsites are updated, remove global lookup from constructor parameters.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jonahwilliams @mingwandroid
[flutter_tools] update device discovery constructors (flutter#61640)
726023e 
google3 callsites are updated, remove global lookup from constructor parameters.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonahwilliams @jmagman @googlebot @zanderso @fluttergithubbot