[flutter_tools] update pubspec .yaml message should not be displayed when creating a new plugin #62599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
tool
jmagman
approved these changes
Jul 30, 2020
| @@ -36,6 +37,7 @@ final Generator _kNoColorTerminalPlatform = () => FakePlatform.fromPlatform(cons | |||
| final Map<Type, Generator> noColorTerminalOverride = <Type, Generator>{ | |||
| Platform: _kNoColorTerminalPlatform, | |||
| }; | |||
| final BufferLogger logger = BufferLogger.test(); | |||
There was a problem hiding this comment.
Add this in main() under `LoggingProcessManager loggingProcessManager;
jmagman
reviewed
Jul 30, 2020
| @@ -49,6 +49,7 @@ void main() { | |||
| Directory projectDir; | |||
| FlutterVersion mockFlutterVersion; | |||
| LoggingProcessManager loggingProcessManager; | |||
| BufferLogger logger = BufferLogger.test(); | |||
There was a problem hiding this comment.
Sorry, I also meant because logger = BufferLogger.test() is in setUp, match the pattern of LoggingProcessManager and just declare it here.
There was a problem hiding this comment.
Yeah I did that and forgot the remove the other constructor call. Fixed in a new commit.
jmagman
reviewed
Jul 30, 2020
| @@ -49,6 +49,7 @@ void main() { | |||
| Directory projectDir; | |||
| FlutterVersion mockFlutterVersion; | |||
| LoggingProcessManager loggingProcessManager; | |||
| BufferLogger logger = BufferLogger.test(); | |||
There was a problem hiding this comment.
Suggested change
| BufferLogger logger = BufferLogger.test(); | |
| BufferLogger logger; |
added 2 commits
July 30, 2020 12:54
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
…when creating a new plugin (flutter#62599) * update pubspec message should not be displayed when creating a new plugin * formatting * revikew * review * cleanup
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…when creating a new plugin (flutter#62599) * update pubspec message should not be displayed when creating a new plugin * formatting * revikew * review * cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where the update
pubspec.yamlmessage always display even when creating a new plugin.Related Issues
fixes #62594
Tests
flutter create -t plugin in an empty folder should not show pubspec.yaml updating suggestion
flutter create -t plugin in an existing plugin should show pubspec.yaml updating suggestion
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.