Share build command flag configuration on desktop #64983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all of the flag setup on Linux, macOS, and Windows should be identical; this pulls that common setup to a shared method. This adds support for several flags on macOS that have all the necessary plumbing already in place due to shared backend code, but were never enabled. Fixes flutter#64944
flutter-dashboard
bot
added
the
tool
| @@ -112,7 +112,7 @@ void main() { | |||
| createCoreMockProjectFiles(); | |||
|
|
|||
| expect(createTestCommandRunner(command).run( | |||
| const <String>['build', 'macos'] | |||
| const <String>['build', 'macos', '--no-pub'] | |||
There was a problem hiding this comment.
Oh hey, this was another bug we needed to fix
There was a problem hiding this comment.
I can't find the original issue, but we did not correctly run pub when building for macos
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Almost all of the flag setup on Linux, macOS, and Windows should be identical; this pulls that common setup to a shared method. This adds support for several flags on macOS that have all the necessary plumbing already in place due to shared backend code, but were never enabled. Fixes flutter#64944
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Almost all of the flag setup on Linux, macOS, and Windows should be
identical; this pulls that common setup to a shared method.
This adds support for several flags on macOS that have all the necessary
plumbing already in place due to shared backend code, but were never
enabled.
Related Issues
Fixes #64944
Fixes #46236
Tests
I added the following tests: macOS version of the existing Windows/Linux tests that verify that the various flags result in the correct native build configurations.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.