[flutter_tools] remove globals from FlutterValidator, add documentation and move tests to new file #67234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
tool
jonahwilliams
changed the title
jonahwilliams
commented
Oct 5, 2020
…r_version_validator
…liams/flutter into split_flutter_version_validator
jonahwilliams
commented
Oct 5, 2020
| @@ -28,16 +28,6 @@ class DoctorCommand extends FlutterCommand { | |||
| @override | |||
| final String description = 'Show information about the installed tooling.'; | |||
|
|
|||
| @override | |||
| Future<Set<DevelopmentArtifact>> get requiredArtifacts async { | |||
There was a problem hiding this comment.
See comment below on Flutter validator
jonahwilliams
commented
Oct 5, 2020
| buf.writeln(userMessages.flutterBinariesDoNotRun); | ||
| if (globals.platform.isLinux) { | ||
| buf.writeln(userMessages.flutterBinariesLinuxRepairCommands); | ||
| // If the binaries are not downloaded (because android is not enabled), then do |
There was a problem hiding this comment.
See #67352 for the issue where we fix + remove this.
Do not need to worry about the binaries being up to date, because gen_snapshot is a native binary and does not need a matching Dart SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove globals from the flutter validator class, and refactor the tests into a separate file. Applies some other cleanup like adding doc comments, and making the doctor validator work like it is documented to work - removing the gen_snapshot check if the artifact is not downloaded instead of downloading all android artifacts.
#47161