-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "[null-safety] reland: migrate app side flutter driver to null-safety" #67570
Reland "[null-safety] reland: migrate app side flutter driver to null-safety" #67570
Conversation
…-revert-67441-migrate_flutter_driver
@@ -26,7 +26,8 @@ class RequestData extends Command { | |||
|
|||
@override | |||
Map<String, String> serialize() => super.serialize()..addAll(<String, String>{ | |||
'message': message, | |||
if (message != null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, OK, I was misunderstanding the !
because I wasn't seeing the != null around it; it's used to remove the ?
from the type of the variable. Cool beans!
import '../../common.dart'; | ||
|
||
void main() { | ||
test('RequestData does not insert "null" string when no message is provided', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested this on my local repro of #67560, it seems to do the trick!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reverts #67561
Fixes insertion of
null
string into message data which crashed integration with web driver. Adds unit test to coverFixes #67560