Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception to FakeCommand #75545

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Add exception to FakeCommand #75545

merged 1 commit into from
Feb 9, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 6, 2021

Throwing exceptions in FakeCommand's onRun block didn't work for runSync processes. Add an exception parameter to FakeCommand, and adopt in places where that was the only thing being done in onRun.
Fixes #56415

Part of #71511

@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Feb 6, 2021
@jmagman jmagman self-assigned this Feb 6, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 6, 2021
@google-cla google-cla bot added the cla: yes label Feb 6, 2021
jonahwilliams
jonahwilliams approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is much nicer than the onRun block idea

@jmagman jmagman merged commit 152d88a into flutter:master Feb 9, 2021
@jmagman jmagman deleted the pm-exception branch February 9, 2021 18:07
@jmagman jmagman added the c: tech-debt Technical debt, code quality, testing, etc. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
c: tech-debt Technical debt, code quality, testing, etc. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FakeProcessManager doesn't call onRun block
2 participants
@jmagman @jonahwilliams