[flutter_tools] do not use context logger in gradle #75940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jonahwilliams
commented
Feb 12, 2021
| final List<int> bytes = file.readAsBytesSync(); | ||
| globals.printTrace('calculateSha: reading file took ${sw.elapsedMilliseconds}us'); |
There was a problem hiding this comment.
I reviewed the data here and basically this is always super fast, the reported issue was likely unrelated
zanderso
approved these changes
Feb 12, 2021
| @@ -169,7 +169,7 @@ void createSettingsAarGradle(Directory androidDirectory) { | |||
| final String currentFileContent = currentSettingsFile.readAsStringSync(); | |||
|
|
|||
| final String newSettingsRelativeFile = globals.fs.path.relative(newSettingsFile.path); | |||
| final Status status = globals.logger.startProgress('✏️ Creating `$newSettingsRelativeFile`...'); | |||
| final Status status = logger.startProgress('✏️ Creating `$newSettingsRelativeFile`...'); | |||
There was a problem hiding this comment.
Could you check that ✏️ is in the list to rewrite when emoji aren't supported? I think it's base/console.dart or base/terminal.dart?
There was a problem hiding this comment.
It wasn't. I added it to the list, and added tests for the rewriting since I couldn't find any
|
Part of #71511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 999 to clean up gradle.dart . move the logger into the class definition and remove context usage. Also removes sha analytics event that has not been useful (its always pretty fast 🤷🏻♂️ ).