New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem causing tasks to timeout. #76028
Conversation
This is because the command was actually collecting logs continuously from the device. Additionally idevicesyslog does not have a reboot option. Bug: flutter#76027
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is because the command was actually collecting logs continuously from the device. Additionally idevicesyslog does not have a reboot option. Bug: flutter#76027
* Avoid iOS local networking dialog in integration tests (#75163) * ios_platform_view tests pass when device rotated (#75665) * Consolidate ascii spinner stop in devtools activation (#75679) * Fix problem causing tasks to timeout. (#76028) This is because the command was actually collecting logs continuously from the device. Additionally idevicesyslog does not have a reboot option. Bug: #76027 * fix Autovalidate enum references in fix data (#77419) * roll engine cherrypicks Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: godofredoc <54371434+godofredoc@users.noreply.github.com> Co-authored-by: Phil Quitslund <pq@users.noreply.github.com>
Ok |
This is because the command was actually collecting logs continuously
from the device. Additionally idevicesyslog does not have a reboot
option.
Bug: #76027
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.