ios_platform_view tests pass when device rotated #75665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Mar 17, 2021
christopherfujino
added a commit
that referenced
this pull request
Mar 19, 2021
* Avoid iOS local networking dialog in integration tests (#75163) * ios_platform_view tests pass when device rotated (#75665) * Consolidate ascii spinner stop in devtools activation (#75679) * Fix problem causing tasks to timeout. (#76028) This is because the command was actually collecting logs continuously from the device. Additionally idevicesyslog does not have a reboot option. Bug: #76027 * fix Autovalidate enum references in fix data (#77419) * roll engine cherrypicks Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: godofredoc <54371434+godofredoc@users.noreply.github.com> Co-authored-by: Phil Quitslund <pq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
becomes
Fixes #75648