Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] remove mocks from android SDK tests #76887

Merged

Conversation

jonahwilliams
Copy link
Member

#71511

Replaces MockProcessManager with FakeProcessManager and removes mock that could have been a top level method.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 26, 2021
@google-cla google-cla bot added the cla: yes label Feb 26, 2021
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ nit

processManager.addCommand(
const FakeCommand(
command: <String>[
'/.tmp_rand0/flutter_mock_android_sdk.rand0/tools/bin/sdkmanager.bat',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation.

@jonahwilliams
Copy link
Member Author

oops, forgot to override the platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants