Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download platform artifacts from assemble if needed #78272

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Download platform artifacts from assemble if needed #78272

merged 1 commit into from
Mar 16, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 16, 2021 •
edited
Loading

Download missing target platform artifacts when run from flutter assemble -dTargetPlatform. This isn't needed from flutter build or flutter run, but is if the user upgrades, then tries to run from Xcode or Gradle.

From Xcode we can see it work:

Showing Recent Messages
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[  +10 ms] Downloading ios tools...
[ +371 ms] Content https://storage.googleapis.com/flutter_infra_release/flutter/20375cebcf3584a23e424e8a722806f77702fa85/ios/artifacts.zip md5 hash: /OZ8Zg+JOPPP+hpcLdYAFQ==
...

Fixes #68475
I KNOW there was an iOS version of this issue but now I can't find it, but I've hit this problems with engine/dart mismatches myself.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: gradle "flutter build" and "flutter run" on Android t: xcode "xcodebuild" on iOS and general Xcode project management labels Mar 16, 2021
@jmagman jmagman self-assigned this Mar 16, 2021
@google-cla google-cla bot added the cla: yes label Mar 16, 2021
jmagman
jmagman commented Mar 16, 2021
View reviewed changes
packages/flutter_tools/lib/src/runner/flutter_command.dart
@@ -1374,31 +1374,10 @@ mixin DeviceBasedDevelopmentArtifacts on FlutterCommand {
}
}

/// A mixin which applies an implementation of [requiredArtifacts] that only
/// downloads artifacts corresponding to a target device.
mixin TargetPlatformBasedDevelopmentArtifacts on FlutterCommand {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead as of #70898

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

jonahwilliams
jonahwilliams approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit b3fa6eb into flutter:master Mar 16, 2021
@jmagman jmagman deleted the assemble-artifacts branch March 16, 2021 20:51
@iapicca iapicca mentioned this pull request Mar 27, 2021
Closed
@iapicca iapicca mentioned this pull request Apr 16, 2021
Closed
@iapicca iapicca mentioned this pull request Apr 24, 2021
Closed
@pedromassangocode pedromassangocode mentioned this pull request May 6, 2021
Closed
@huycozy huycozy mentioned this pull request Oct 24, 2022
Closed
@dam-ease dam-ease mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
t: gradle "flutter build" and "flutter run" on Android t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
3 participants
@jmagman @jonahwilliams @fluttergithubbot